From: 'alvherre@alvh.no-ip.org' <alvherre@alvh.no-ip.org>
To: tsunakawa.takay@fujitsu.com <tsunakawa.takay@fujitsu.com>
Cc: iwata.aya@fujitsu.com <iwata.aya@fujitsu.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: tgl@sss.pgh.pa.us <tgl@sss.pgh.pa.us>
Cc: k.jamison@fujitsu.com <k.jamison@fujitsu.com>
Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Subject: Re: libpq debug log
Date: Mon, 29 Mar 2021 00:02:58 -0300
Message-ID: <20210329030258.GA25869@alvherre.pgsql> (raw)
In-Reply-To: <TYAPR01MB29900BDAA0822F0543652661FE7E9@TYAPR01MB2990.jpnprd01.prod.outlook.com>
On 2021-Mar-29, tsunakawa.takay@fujitsu.com wrote:
> > (Hey, what the heck is that "Z" at the end of the message? I thought
> > the error ended right at the \x00 ...)
>
> We'll investigate these issues.
For what it's worth, I did fix this problem in patch 0005 that I
attached. The problem was that one "continue" should have been "break",
and also a "while ( .. )" needed to be made an infinite loop. It was
easy to catch these problems once I added (in 0006) the check that the
bytes consumed equal message length, as I had suggested a couple of
weeks ago :-) I also changed the code for Notice, but I didn't actually
verify that one.
> > 2. The < and > characters are not good for visual inspection. I
> > replaced them with F and B and I think it's much clearer. Compare:
> > I think the second one is much easier on the eye.
>
> Yes, agreed. I too thought of something like "C->S" and "S->C"
> because client and server should be more familiar for users than
> frontend and backend.
Hmm, yeah, that's a reasonable option too. What do others think?
--
Álvaro Herrera Valdivia, Chile
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, tsunakawa.takay@fujitsu.com, iwata.aya@fujitsu.com, horikyota.ntt@gmail.com, tgl@sss.pgh.pa.us, k.jamison@fujitsu.com, pgsql-hackers@lists.postgresql.org
Subject: Re: libpq debug log
In-Reply-To: <20210329030258.GA25869@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox