From: Bruce Momjian <bruce@momjian.us>
To: Christoph Berg <myon@debian.org>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: compute_query_id and pg_stat_statements
Date: Mon, 26 Apr 2021 12:21:04 -0400
Message-ID: <20210426162104.GQ7629@momjian.us> (raw)
In-Reply-To: <YIbdhrfemBnwAvl5@msg.df7cb.de>
References: <35457b09-36f8-add3-1d07-6034fa585ca8@oss.nttdata.com>
<20210424152220.GL7629@momjian.us>
<CABUevEx4YQi42MwaMq3Bo09=mBqfjUqtkp5NUZpnQ0HdX+5+Hw@mail.gmail.com>
<20210424170908.GM7629@momjian.us>
<1709439.1619286231@sss.pgh.pa.us>
<e832ac41-00dd-3a05-7f52-4b2ae4613508@enterprisedb.com>
<YIbdhrfemBnwAvl5@msg.df7cb.de>
On Mon, Apr 26, 2021 at 05:34:30PM +0200, Christoph Berg wrote:
> Re: Peter Eisentraut
> > > Agreed. If pg_stat_statements were zero-configuration today then
> > > this would be an annoying new burden, but it isn't.
> >
> > I think people can understand "add pg_stat_statements to
> > shared_preload_libraries" and "install the extension". You have to turn it
> > on somehow after all.
>
> Fwiw, I'd claim that pg_stat_statements *is* zero-configuration today.
> You just have to load the module (= shared_preload_libraries), and it
> will start working. Later you can run CREATE EXTENSION to actually see
> the stats, but they are already being collected in the background.
>
> > Now there is the additional burden of turning on this weird setting that no
> > one understands. That's a 50% increase in burden.
> >
> > And almost no one will want to use a nondefault setting.
> >
> > pg_stat_statements is pretty popular. I think leaving in this requirement
> > will lead to widespread confusion and complaints.
>
> Ack, please make the default config (i.e. after setting shared_preload_libraries)
> do something sensible. Having to enable some "weird" internal other setting
> will be very hard to explain to users.
>
> Fwiw, I'd even want to have pg_stat_statements enabled in core by
> default. That would awesome UX. (And turning off could be as simple as
> setting compute_query_id=off.)
Techically, pg_stat_statements can turn on compute_query_id when it is
loaded, even if it is 'off' in postgresql.conf, right? And
pg_stat_statements would know if an alternate hash method is being used,
right?
This is closer to Magnus's idea of having a three-value
compute_query_id, except is it more controlled by pg_stat_statements.
Another idea would be to throw a user-visible warning if the
pg_stat_statements extension is loaded and compute_query_id is off.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bruce@momjian.us, myon@debian.org, peter.eisentraut@enterprisedb.com, tgl@sss.pgh.pa.us, magnus@hagander.net, masao.fujii@oss.nttdata.com, pgsql-hackers@lists.postgresql.org
Subject: Re: compute_query_id and pg_stat_statements
In-Reply-To: <20210426162104.GQ7629@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox