pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] force_parallel_mode and GUC categories
Date: Wed, 28 Apr 2021 23:24:04 -0500
Message-ID: <20210429042404.GG27406@telsasoft.com> (raw)
In-Reply-To: <YG+y/eJErKPDUhiS@paquier.xyz>
References: <CAN0SRDFV=Fv0zXHCGbh7gh=MTfw05Xd1x7gjJrZs5qn-TEphOw@mail.gmail.com>
	<CAFj8pRDycZjBLBaEkUcY4B01PS=ojoaBgQnzJaqBROTn8KM7Bg@mail.gmail.com>
	<20210403141651.GI6592@telsasoft.com>
	<CAN0SRDF6ZzxV-+OdgP6B+Zg0TmhrYFSOd3kK8GC5mkfo1icEGQ@mail.gmail.com>
	<20210403151201.GD29125@momjian.us>
	<3972636.1617464359@sss.pgh.pa.us>
	<20210403154114.GJ6592@telsasoft.com>
	<20210403154336.GG29125@momjian.us>
	<20210404012546.GK6592@telsasoft.com>
	<YG+y/eJErKPDUhiS@paquier.xyz>

On Fri, Apr 09, 2021 at 10:50:53AM +0900, Michael Paquier wrote:
> -       {"track_commit_timestamp", PGC_POSTMASTER, REPLICATION,
> +       {"track_commit_timestamp", PGC_POSTMASTER, REPLICATION_SENDING,
> I can get behind this change for clarity where it gets actively used.

I'm not sure what you meant?

...but, I realized just now that *zero* other GUCs use "REPLICATION".
And the documentation puts it in 20.6.1. Sending Servers,
so it still seems to me that this is correct to move this, too.

https://www.postgresql.org/docs/devel/runtime-config-replication.html

Then, I wonder if REPLICATION should be removed from guc_tables.h...

-- 
Justin





view thread (18+ messages)  latest in thread

Message-ID: <20210429042404.GG27406@telsasoft.com>
Permalink:  ../20210429042404.GG27406@telsasoft.com/
Also on:    postgresql.org/message-id/20210429042404.GG27406@telsasoft.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, michael@paquier.xyz, bruce@momjian.us, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
  Subject: Re: [PATCH] force_parallel_mode and GUC categories
  In-Reply-To: <20210429042404.GG27406@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox