From: Justin Pryzby <pryzby@telsasoft.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Hubert Zhang <zhubert@vmware.com>
Cc: tsunakawa.takay@fujitsu.com, pgsql-hackers@postgresql.org, Andreas Seltenreich <seltenreich@gmx.de>
Cc: Bruce Momjian <bruce@momjian.us>
Subject: Re: Multiple hosts in connection string failed to failover in non-hot standby mode
Date: Thu, 6 May 2021 12:38:13 -0500
Message-ID: <20210506173813.GN27406@telsasoft.com> (raw)
In-Reply-To: <4170264.1620321747@sss.pgh.pa.us>
References: <BN6PR05MB3492948E4FD76C156E747E8BC9160@BN6PR05MB3492.namprd05.prod.outlook.com>
<TYAPR01MB299012CAC510D2644AEC2246FE160@TYAPR01MB2990.jpnprd01.prod.outlook.com>
<BN6PR05MB3492DFB2FF32B771172CC2F2C9170@BN6PR05MB3492.namprd05.prod.outlook.com>
<229507.1610056206@sss.pgh.pa.us>
<770711.1610318330@sss.pgh.pa.us>
<20210506162651.GJ27406@telsasoft.com>
<4170264.1620321747@sss.pgh.pa.us>
On Thu, May 06, 2021 at 01:22:27PM -0400, Tom Lane wrote:
> I'm curious though why it took this long for anyone to complain.
> I'd supposed that people were running sqlsmith against HEAD on
> a pretty regular basis.
I think it's also becase sqlsmith would need to run against the v14 *client*
library. I don't know about anyone else's workflow, but I tend not to "make
install", but work with binaries out of ./tmp_install.
There's a few changes needed on sqlsmith HEAD, but I guess nobody would have
gotten that far if the connection was failing (or rather, detected as such).
diff --git a/grammar.cc b/grammar.ccindex 62aa8e9..76491ff 100644--- a/grammar.cc+++ b/grammar.cc@@ -327,7 +327,11 @@ query_spec::query_spec(prod *p, struct scope *s, bool lateral) :
search = bool_expr::factory(this);
- if (d6() > 2) {+ if (d6() > 4) {+ ostringstream cons;+ cons << "order by 1 fetch first " << d100() + d100() << " rows with ties";+ limit_clause = cons.str();+ } else if (d6() > 2) {
ostringstream cons;
cons << "limit " << d100() + d100();
limit_clause = cons.str();
diff --git a/postgres.cc b/postgres.ccindex f2a3627..1c0c55f 100644--- a/postgres.cc+++ b/postgres.cc@@ -30,6 +30,7 @@ bool pg_type::consistent(sqltype *rvalue)
case 'c': /* composite type */
case 'd': /* domain */
case 'r': /* range */
+ case 'm': /* multirange */
case 'e': /* enum */
return this == t;
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, tgl@sss.pgh.pa.us, zhubert@vmware.com, seltenreich@gmx.de, bruce@momjian.us
Subject: Re: Multiple hosts in connection string failed to failover in non-hot standby mode
In-Reply-To: <20210506173813.GN27406@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox