From: Álvaro Herrera <alvherre@alvh.no-ip.org>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Pavel Luzanov <p.luzanov@postgrespro.ru>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Subject: Re: ALTER TABLE .. DETACH PARTITION CONCURRENTLY
Date: Thu, 6 May 2021 16:48:29 -0400
Message-ID: <20210506204829.GA8989@alvherre.pgsql> (raw)
In-Reply-To: <CA+HiwqHJK7H6g8+rMhyMtxjgXefzdEk2yKTdB3LCFdNMw4Ct+w@mail.gmail.com>
On 2021-May-06, Amit Langote wrote:
> That makes sense, thanks for noticing.
>
> How about the attached?
I tweaked the linkage; as submitted, the text in the link contained what
is in the <term> tag, so literally it had:
... see DETACH PARTITION partition_name [ CONCURRENTLY | FINALIZE ] for
details ...
which didn't look very nice. So I made it use <link> instead of xref
and wrote the "ALTER TABLE .. DETACH PARTITION" text. I first tried to
fix it by adding an "xreflabel" attrib, but I didn't like it because the
text was not set in fixed width font.
I also tweaked the wording to match the surrounding text a bit better,
at least IMO. Feel free to suggest improvements.
Thanks!
--
Álvaro Herrera 39°49'30"S 73°17'W
"That sort of implies that there are Emacs keystrokes which aren't obscure.
I've been using it daily for 2 years now and have yet to discover any key
sequence which makes any sense." (Paul Thomas)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, amitlangote09@gmail.com, p.luzanov@postgrespro.ru, pryzby@telsasoft.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: ALTER TABLE .. DETACH PARTITION CONCURRENTLY
In-Reply-To: <20210506204829.GA8989@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox