From: Justin Pryzby <pryzby@telsasoft.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Christoph Berg <myon@debian.org>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: compute_query_id and pg_stat_statements
Date: Fri, 14 May 2021 19:10:17 -0500
Message-ID: <20210515001017.GU27406@telsasoft.com> (raw)
In-Reply-To: <20210514235013.GA16112@alvherre.pgsql>
References: <20210514035733.hkcf3alnbyofmplu@nol>
<20210514235013.GA16112@alvherre.pgsql>
On Fri, May 14, 2021 at 07:50:13PM -0400, Alvaro Herrera wrote:
> +++ b/doc/src/sgml/config.sgml
> @@ -7643,7 +7643,12 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv;
> identifier to be computed. Note that an external module can
> alternatively be used if the in-core query identifier computation
> method is not acceptable. In this case, in-core computation
> - must be disabled. The default is <literal>off</literal>.
> + must be always disabled.
> + Valid values are <literal>off</literal> (always disabled),
> + <literal>on</literal> (always enabled) and <literal>auto</literal>,
> + which let modules such as <xref linkend="pgstatstatements"/>
> + automatically enable it.
> + The default is <literal>auto</literal>.
which lets
> +/* True when a module requests query IDs and they're set auto */
> +bool query_id_enabled = false;
Does "they're" mean the GUC compute_query_id ?
> +/*
> + * This should only be called if IsQueryIdEnabled()
> + * return true.
> + */
> JumbleState *
> JumbleQuery(Query *query, const char *querytext)
Should it Assert() that ?
Maybe you should update this too ?
doc/src/sgml/release-14.sgml
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, alvherre@alvh.no-ip.org, rjuju123@gmail.com, masao.fujii@oss.nttdata.com, pavel.stehule@gmail.com, horikyota.ntt@gmail.com, magnus@hagander.net, michael@paquier.xyz, andres@anarazel.de, tgl@sss.pgh.pa.us, sfrost@snowman.net, bruce@momjian.us, myon@debian.org, peter.eisentraut@enterprisedb.com, pgsql-hackers@lists.postgresql.org
Subject: Re: compute_query_id and pg_stat_statements
In-Reply-To: <20210515001017.GU27406@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox