From: Bruce Momjian <bruce@momjian.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Christoph Berg <myon@debian.org>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: compute_query_id and pg_stat_statements
Date: Sat, 15 May 2021 17:32:58 -0400
Message-ID: <20210515213258.GA21748@momjian.us> (raw)
In-Reply-To: <20210515182159.GA11009@alvherre.pgsql>
References: <CAOBaU_as6VhWyy4OvdM+McRNdSbfJ7Dk_k1wU04E8a=wxCpuTw@mail.gmail.com>
<20210515182159.GA11009@alvherre.pgsql>
On Sat, May 15, 2021 at 02:21:59PM -0400, Álvaro Herrera wrote:
> I commented out the release notes para that is now wrong. What remains
> is this:
>
> Move query hash computation from pg_stat_statements to the core server (Julien Rouhaud)
>
> We could perhaps add something like
>
> Extension pg_stat_statements continues to work without requiring any
> configuration changes.
>
> but that seems a bit pointless. Or maybe
>
> Extension pg_stat_statements automatically enables query identifier
> computation if compute_query_id is set to auto. Third-party modules
> to compute query identifiers can be installed and used if this is set
> to off.
>
OK, new text is:
<listitem>
<!--
Author: Bruce Momjian <bruce@momjian.us>
2021-04-07 [5fd9dfa5f] Move pg_stat_statements query jumbling to core.
-->
<para>
Move query hash computation from pg_stat_statements to the core
server (Julien Rouhaud)
</para>
<para>
The new server variable compute_query_id's default of 'auto' will
automatically enable query id computation when this extension
is loaded.
</para>
</listitem>
I also added Alvaro as an author of the compute_query_id item.
> I wonder why the initial line says "query hash" instead of "query
> identifier". Do we want to say "hash" everywhere? Why didn't we name
> the GUC "compute_query_hash" in that case?
It is queryid (no underscore) in pg_stat_statements, which was a whole
different discussion. ;-)
> Anyway, let me remind you that it is pretty common to require initdb
> during the beta period.
True.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bruce@momjian.us, alvherre@alvh.no-ip.org, rjuju123@gmail.com, masao.fujii@oss.nttdata.com, pavel.stehule@gmail.com, horikyota.ntt@gmail.com, magnus@hagander.net, michael@paquier.xyz, andres@anarazel.de, tgl@sss.pgh.pa.us, sfrost@snowman.net, myon@debian.org, peter.eisentraut@enterprisedb.com, pgsql-hackers@lists.postgresql.org
Subject: Re: compute_query_id and pg_stat_statements
In-Reply-To: <20210515213258.GA21748@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox