From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Jeff Davis <pgsql@j-davis.com>
Cc: pgsql-hackers@postgresql.org, Jacob Champion <pchampion@vmware.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Ashwin Agrawal <aagrawal@pivotal.io>
Cc: Ashutosh Sharma <ashu.coek88@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Subject: Re: alter table set TABLE ACCESS METHOD
Date: Wed, 9 Jun 2021 21:35:06 -0500
Message-ID: <20210610023506.GZ16435@telsasoft.com> (raw)
In-Reply-To: <YMBH1nt8XXi8l7NY@paquier.xyz>
References: <20210308010707.GA29832@telsasoft.com>
<YEXSj7vO/ypnlIqq@paquier.xyz>
<35333ea26e52252174515e14671a9fbc1c20c8fa.camel@j-davis.com>
<20210506202305.GQ27406@telsasoft.com>
<1033d6b4b5b42a014cc3f617265ae6e61cb5781b.camel@j-davis.com>
<20210506221943.GS27406@telsasoft.com>
<3bee08c2ca0fab15d14899afcb19490f29e0ec6f.camel@j-davis.com>
<803b32e45baf0b05e5f3fc144383db3a18081693.camel@j-davis.com>
<27c94b85d966351e2715cdbf79cb4c658b3cfaa7.camel@j-davis.com>
<YMBH1nt8XXi8l7NY@paquier.xyz>
On Wed, Jun 09, 2021 at 01:47:18PM +0900, Michael Paquier wrote:
> On Tue, Jun 08, 2021 at 05:33:31PM -0700, Jeff Davis wrote:
> > New version attached, with the detoasting code removed. Could use
> > another round of validation/cleanup in case I missed something during
> > the merge.
>
> This looks rather sane to me, thanks.
>
> /* Create the transient table that will receive the re-ordered data */
> OIDNewHeap = make_new_heap(tableOid, tableSpace,
> + accessMethod
> It strikes me that we could extend CLUSTER/VACUUM FULL to support this
> option, in the same vein as TABLESPACE. Perhaps that's not something to
> implement or have, just wanted to mention it.
It's a good thought. But remember that that c5b28604 handled REINDEX
(TABLESPACE) but not CLUSTER/VACUUM FULL (TABLESPACE). You wrote:
https://www.postgresql.org/message-id/YBuWbzoW6W7AaMv0%40paquier.xyz> Regarding the VACUUM and CLUSTER cases, I am not completely sure if
> going through these for a tablespace case is the best move we can do,
> as ALTER TABLE is able to mix multiple operations and all of them
> require already an AEL to work. REINDEX was different thanks to the
> case of CONCURRENTLY. Anyway, as a lot of work has been done here
> already, I would recommend to create new threads about those two
> topics. I am also closing this patch in the CF app.
In any case, I think we really want to have an ALTER .. SET ACCESS METHOD.
Supporting it also in CLUSTER/VACUUM is an optional, additional feature.
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, michael@paquier.xyz, pgsql@j-davis.com, pchampion@vmware.com, hlinnaka@iki.fi, aagrawal@pivotal.io, ashu.coek88@gmail.com, andres@anarazel.de, robertmhaas@gmail.com, amit.kapila16@gmail.com, alvherre@alvh.no-ip.org, dilipbalaut@gmail.com
Subject: Re: alter table set TABLE ACCESS METHOD
In-Reply-To: <20210610023506.GZ16435@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox