From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Simon Riggs <simon.riggs@enterprisedb.com>
Subject: Re: logical replication of truncate command with trigger causes Assert
Date: Sat, 12 Jun 2021 14:43:08 -0400
Message-ID: <202106121843.c4uagunajhpm@alvherre.pgsql> (raw)
In-Reply-To: <2321999.1623517262@sss.pgh.pa.us>
On 2021-Jun-12, Tom Lane wrote:
> Amit Kapila <amit.kapila16@gmail.com> writes:
> > On Fri, Jun 11, 2021 at 8:56 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >> I was thinking maybe we could mark all these replication protocol
> >> violation errors non-translatable. While we don't want to crash on a
> >> protocol violation, it shouldn't really be a user-facing case either.
>
> > I don't see any problem with that as these are not directly related to
> > any user operation. So, +1 for making these non-translatable.
>
> Done that way.
Good call, thanks. Not only it's not very useful to translate such
messages, but it's also quite a burden because some of them are
difficult to translate.
--
Álvaro Herrera Valdivia, Chile
"Tiene valor aquel que admite que es un cobarde" (Fernandel)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, tgl@sss.pgh.pa.us, amit.kapila16@gmail.com, mark.dilger@enterprisedb.com, pgsql-hackers@lists.postgresql.org, peter.eisentraut@enterprisedb.com, simon.riggs@enterprisedb.com
Subject: Re: logical replication of truncate command with trigger causes Assert
In-Reply-To: <202106121843.c4uagunajhpm@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox