From: Justin Pryzby <pryzby@telsasoft.com>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: pgsql-hackers@postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Andres Freund <andres@anarazel.de>
Subject: Re: Different compression methods for FPI
Date: Tue, 15 Jun 2021 11:14:56 -0500
Message-ID: <20210615161456.GP31772@telsasoft.com> (raw)
In-Reply-To: <d220fdbf-c9fc-6408-ff2b-07f5a9a23e2c@enterprisedb.com>
References: <3252174C-C21D-4711-A038-5230DE465BAE@yandex-team.ru>
<YLWWPaq/KnVS24J4@paquier.xyz>
<20210614012412.GA31772@telsasoft.com>
<YMf5YQVpDLUf+WoQ@paquier.xyz>
<20210615014208.GK31772@telsasoft.com>
<YMgS3DxyLj7Dqx7S@paquier.xyz>
<20210615034206.GL31772@telsasoft.com>
<a5e263ea-82d3-186f-1abf-a661c5f673af@iki.fi>
<YMg8hz/hpl8Qr3bM@paquier.xyz>
<d220fdbf-c9fc-6408-ff2b-07f5a9a23e2c@enterprisedb.com>
On Tue, Jun 15, 2021 at 07:53:26AM +0200, Peter Eisentraut wrote:
> On 15.06.21 07:37, Michael Paquier wrote:
> > > > Actually, I was just thinking that default yes/no/on/off stuff maybe should be
> > > > defined to mean "lz4" rather than meaning pglz for "backwards compatibility".
> > > +1
> > I am not sure that we have any reasons to be that aggressive about
> > this one either, and this would mean that wal_compression=on implies a
> > different method depending on the build options. I would just stick
> > with the past, careful practice that we have to use a default
> > backward-compatible value as default, while being able to use a new
> > option.
You're right, I hadn't though this through all the way.
There's precedent if the default is non-static (wal_sync_method).
But I think yes/on/true/1 should be a compatibility alias for a static thing,
and then the only option is pglz.
Of course, changing the default to LZ4 is still a possibility.
> If we think this new thing is strictly better than the old thing, then why
> not make it the default. What would be the gain from sticking to the old
> default?
>
> The point that the default would depend on build options is a valid one.
> I'm not sure whether it's important enough by itself.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, peter.eisentraut@enterprisedb.com, michael@paquier.xyz, hlinnaka@iki.fi, x4mmm@yandex-team.ru, thomas.munro@gmail.com, pg@bowt.ie, andres@anarazel.de
Subject: Re: Different compression methods for FPI
In-Reply-To: <20210615161456.GP31772@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox