From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Improving isolationtester's data output
Date: Tue, 15 Jun 2021 19:20:11 -0400
Message-ID: <202106152320.xfiprkh4sp5c@alvherre.pgsql> (raw)
In-Reply-To: <582362.1623798221@sss.pgh.pa.us>
On 2021-Jun-15, Tom Lane wrote:
> I've been spending a lot of time looking at isolationtester results
> over the past couple of days, and gotten really annoyed at how poorly
> it formats query results. In particular, any column heading or value
> that is 15 characters or longer is not separated from the next column,
> rendering the output quite confusing.
Yeah, I noticed this too.
> Attached is a little hack that tries to improve that case while making
> minimal changes to the output files otherwise.
Seems pretty reasonable.
> There's still a good deal to be desired here: notably, the code still
> does nothing to ensure vertical alignment of successive lines when
> there are wide headings or values. But doing anything about that
> would involve much-more-invasive changes of the output files.
> If we wanted to buy into that, I'd think about discarding this
> ad-hoc code altogether in favor of using one of libpq's fe-print.c
> routines. But I'm not really sure that the small legibility gains
> that would result are worth massive changes in the output files.
Shrug -- it's a one time change. It wouldn't bother me, for one.
--
Álvaro Herrera Valdivia, Chile
"Hay que recordar que la existencia en el cosmos, y particularmente la
elaboración de civilizaciones dentro de él no son, por desgracia,
nada idílicas" (Ijon Tichy)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, tgl@sss.pgh.pa.us
Subject: Re: Improving isolationtester's data output
In-Reply-To: <202106152320.xfiprkh4sp5c@alvherre.pgsql>
References: <582362.1623798221@sss.pgh.pa.us> <202106152320.xfiprkh4sp5c@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox