From: Bruce Momjian <bruce@momjian.us>
To: Dave Cramer <davecramer@gmail.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_upgrade does not upgrade pg_stat_statements properly
Date: Thu, 29 Jul 2021 12:34:48 -0400
Message-ID: <20210729163448.GP9600@momjian.us> (raw)
In-Reply-To: <CADK3HH+ytzM80P1bRDc6Hi6KXQBHOSi5Y51XWE8ojGnLHmDjNw@mail.gmail.com>
References: <CAKFQuwZhCVAhsjBX7vnBxAkK1XvzHci=J_-ibZyLpNtrt2fMcg@mail.gmail.com>
<20210729015236.GD9600@momjian.us>
<CAKFQuwaZ_OQw4f_x3RM2hN5_XnM6NT2xW7sT-6a5R5=Qz+7Udw@mail.gmail.com>
<20210729145640.GE9600@momjian.us>
<CAKFQuwapO8wfEY5gQQdd8ouvZNnHd2b+qXZhVS8_70mnSiRJ+w@mail.gmail.com>
<CADK3HHJtWQCjbQns2WkrirnAWR7YEP-LjpH5Gup0gf4+P=sH4A@mail.gmail.com>
<20210729154216.GL9600@momjian.us>
<CAKFQuwZB-SCw7zxqMo362j=KqSkTAS+5ONUP9wrbtpOri4qPQQ@mail.gmail.com>
<20210729161649.GO9600@momjian.us>
<CADK3HH+ytzM80P1bRDc6Hi6KXQBHOSi5Y51XWE8ojGnLHmDjNw@mail.gmail.com>
On Thu, Jul 29, 2021 at 12:22:59PM -0400, Dave Cramer wrote:
> On Thu, 29 Jul 2021 at 12:16, Bruce Momjian <bruce@momjian.us> wrote:
> Can you review the text I just posted? Thanks. I think we are making
> progress. ;-)
>
>
> I am OK with Everything except
>
> Do not load the schema definitions,
> e.g., <command>CREATE EXTENSION pgcrypto</command>, because these
> will be recreated from the old cluster. (The extensions may be
> upgraded later using <literal>ALTER EXTENSION ... UPGRADE</literal>.)
>
> I take issue with the word "recreated". This implies something new is created,
> when in fact the old definitions are simply copied over.
>
> As I said earlier; using the wording "may be upgraded" is not nearly cautionary
> enough.
OK, I changed it to "copy" though I used "recreated" earlier since I was
worried "copy" would be confused with file copy. I changed the
recommendation to "should be".
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
Attachments:pg_upgrade.diff (text/x-diff, 2.0K) downloaddiff --git a/doc/src/sgml/ref/pgupgrade.sgml b/doc/src/sgml/ref/pgupgrade.sgmlindex a83c63cd98..0e69f26628 100644--- a/doc/src/sgml/ref/pgupgrade.sgml+++ b/doc/src/sgml/ref/pgupgrade.sgml@@ -299,15 +299,18 @@ make prefix=/usr/local/pgsql.new install
</step>
<step>
- <title>Install custom shared object files</title>+ <title>Install extension shared object files</title>
<para>
- Install any custom shared object files (or DLLs) used by the old cluster- into the new cluster, e.g., <filename>pgcrypto.so</filename>,- whether they are from <filename>contrib</filename>- or some other source. Do not install the schema definitions, e.g.,- <command>CREATE EXTENSION pgcrypto</command>, because these will be upgraded- from the old cluster.+ If the old cluster used extensions, whether from+ <filename>contrib</filename> or some other source, it used+ shared object files (or DLLs) to implement these extensions, e.g.,+ <filename>pgcrypto.so</filename>. Now, shared object files matching+ the new server binary must be installed in the new cluster, usually+ via operating system commands. Do not load the schema definitions,+ e.g., <command>CREATE EXTENSION pgcrypto</command>, because these+ will be copied from the old cluster. (Extensions should be upgraded+ later using <literal>ALTER EXTENSION ... UPGRADE</literal>.)
Also, any custom full text search files (dictionary, synonym,
thesaurus, stop words) must also be copied to the new cluster.
</para>
@@ -494,10 +497,10 @@ pg_upgrade.exe
</step>
<step>
- <title>Install custom shared object files</title>+ <title>Install extension shared object files</title>
<para>
- Install the same custom shared object files on the new standbys+ Install the same extension shared object files on the new standbys
that you installed in the new primary cluster.
</para>
</step>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bruce@momjian.us, davecramer@gmail.com, david.g.johnston@gmail.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade does not upgrade pg_stat_statements properly
In-Reply-To: <20210729163448.GP9600@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox