From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Bossart, Nathan <bossartn@amazon.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: x4mmm@yandex-team.ru <x4mmm@yandex-team.ru>
Cc: a.lubennikova@postgrespro.ru <a.lubennikova@postgrespro.ru>
Cc: hlinnaka@iki.fi <hlinnaka@iki.fi>
Cc: matsumura.ryo@fujitsu.com <matsumura.ryo@fujitsu.com>
Cc: masao.fujii@gmail.com <masao.fujii@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: archive status ".ready" files may be created too early
Date: Fri, 30 Jul 2021 14:33:15 -0400
Message-ID: <202107301833.7lyjghlns3hb@alvherre.pgsql> (raw)
In-Reply-To: <EBD2D598-B3B9-4923-A1B8-76A4AEC631B6@amazon.com>
On 2021-Jul-28, Bossart, Nathan wrote:
> On 7/27/21, 6:05 PM, "Alvaro Herrera" <alvherre@alvh.no-ip.org> wrote:
> > I'm not sure I understand what's the reason not to store this value in
> > pg_control; I feel like I'm missing something. Can you please explain?
>
> Thanks for taking a look.
>
> The only reason I can think of is that it could make back-patching
> difficult. I don't mind working on a version of the patch that uses
> pg_control. Back-patching this fix might be a stretch, anyway.
Hmm ... I'm not sure we're prepared to backpatch this kind of change.
It seems a bit too disruptive to how replay works. I think patch we
should be focusing solely on patch 0001 to surgically fix the precise
bug you see. Does patch 0002 exist because you think that a system with
only 0001 will not correctly deal with a crash at the right time?
Now, the reason I'm looking at this patch series is that we're seeing a
related problem with walsender/walreceiver, which apparently are capable
of creating a file in the replica that ends up not existing in the
primary after a crash, for a reason closely related to what you
describe for WAL archival. I'm not sure what is going on just yet, so
I'm not going to try and explain because I'm likely to get it wrong.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, bossartn@amazon.com, horikyota.ntt@gmail.com, x4mmm@yandex-team.ru, a.lubennikova@postgrespro.ru, hlinnaka@iki.fi, matsumura.ryo@fujitsu.com, masao.fujii@gmail.com
Subject: Re: archive status ".ready" files may be created too early
In-Reply-To: <202107301833.7lyjghlns3hb@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox