From: Bruce Momjian <bruce@momjian.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Denis Laxalde <denis.laxalde@dalibo.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Disable bgworkers during servers start in pg_upgrade
Date: Thu, 26 Aug 2021 09:42:29 -0400
Message-ID: <20210826134229.GC22637@momjian.us> (raw)
In-Reply-To: <2CD2F784-E80C-4B0D-A038-A0D44DD4EDC4@yesql.se>
References: <20210124003611.lkyxhd2mpdmv5xzh@alap3.anarazel.de>
<20210127102511.tvhu2wmrxoz3tle4@dalibo.com>
<20210127144132.215fe4bb@firost>
<20210312082325.weltivlokfpc3gt2@nol>
<e7d8042b-e5a2-6093-e20e-15743c1a2843@dalibo.com>
<YSXUwqCdhJWjPl1S@paquier.xyz>
<7d470953-07cb-f9dc-f7b3-d33697644b54@dalibo.com>
<CAOBaU_Zh5K_kjCAX+OnwRMQ68SHSVSR5haF9R0Ud8hXk31Wk+Q@mail.gmail.com>
<20210826130945.GB22637@momjian.us>
<2CD2F784-E80C-4B0D-A038-A0D44DD4EDC4@yesql.se>
On Thu, Aug 26, 2021 at 03:38:23PM +0200, Daniel Gustafsson wrote:
> > On 26 Aug 2021, at 15:09, Bruce Momjian <bruce@momjian.us> wrote:
> > On Thu, Aug 26, 2021 at 03:24:33PM +0800, Julien Rouhaud wrote:
>
> >> .. I still think that
> >> changing bgworker_should_start_now() is a better option.
> >
> > I am not sure. We have a lot of pg_upgrade code that turns off things
> > like autovacuum and that has worked fine:
>
> True, but there are also conditionals on IsBinaryUpgrade for starting the
> autovacuum launcher in the postmaster, so there is some precedent.
Oh, I was not aware of that.
> > Basically, pg_upgrade has avoided any backend changes that could be
> > controlled by GUCs and I am not sure we want to start adding such
> > changes for just this.
>
> In principle I think it’s sound to try to avoid backend changes where possible
> without sacrificing robustness.
Agreed.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bruce@momjian.us, daniel@yesql.se, rjuju123@gmail.com, denis.laxalde@dalibo.com, michael@paquier.xyz, jgdr@dalibo.com, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Disable bgworkers during servers start in pg_upgrade
In-Reply-To: <20210826134229.GC22637@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox