From: Noah Misch <noah@leadboat.com>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Postgres perl module namespace
Date: Fri, 3 Sep 2021 23:19:49 -0700
Message-ID: <20210904061949.GA2326091@rfd.leadboat.com> (raw)
In-Reply-To: <ce3dc94c-2826-e2b3-42f7-dd0cecf9526c@dunslane.net>
References: <202108111322.cj455y35dc2c@alvherre.pgsql>
<3967644.1628688608@sss.pgh.pa.us>
<7b565e73-4adc-ee9f-bc61-34817298978d@dunslane.net>
<CA+TgmobdrGo2PcxLYXr3DLVVHxt-Xp9dmkSsRuXSNRBasgrGxg@mail.gmail.com>
<YSXZt7sJWJEz76F3@paquier.xyz>
<CA+TgmoazCbbtxGEUaFFkArYxq_8r1iwL4kNG+fzJTzcDPRVfBw@mail.gmail.com>
<ce3dc94c-2826-e2b3-42f7-dd0cecf9526c@dunslane.net>
On Fri, Sep 03, 2021 at 03:34:24PM -0400, Andrew Dunstan wrote:
> On 8/25/21 10:08 AM, Robert Haas wrote:
> > On Wed, Aug 25, 2021 at 1:48 AM Michael Paquier <michael@paquier.xyz> wrote:
> >> On Mon, Aug 23, 2021 at 03:39:15PM -0400, Robert Haas wrote:
> >>> On Mon, Aug 23, 2021 at 3:03 PM Andrew Dunstan <andrew@dunslane.net> wrote:
> >>>> OK, I count 3 in favor of changing to PgTest::Cluster, 1 against,
> >>>> remainder don't care.
> >>> I'd have gone with something starting with Postgres:: ... but I don't care much.
> >> PgTest seems like a better choice to me, as "Postgres" could be used
> >> for other purposes than a testing framework, and the argument that
> >> multiple paths makes things annoying for hackers is sensible.
> > I mean, it's a hierarchical namespace. The idea is you do
> > Postgres::Test or Postgres::<whatever> and other people using the
> > Postgres database can use other parts of it. But again, not really
> > worth arguing about.
>
> I think I have come around to this POV. Here's a patch. The worst of it
> is changes like this:
>
> - my $node2 = PostgresNode->new('replica');
> + my $node2 = Postgres::Test::Cluster->new('replica');
> ...
> - TestLib::system_or_bail($tar, 'xf', $tblspc_tars[0], '-C', $repTsDir);
> + Postgres::Test::Utils::system_or_bail($tar, 'xf', $tblspc_tars[0], '-C', $repTsDir);
plperl uses PostgreSQL:: as the first component of its Perl module namespace.
We shouldn't use both PostgreSQL:: and Postgres:: in the same source tree, so
this change should not use Postgres::.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: noah@leadboat.com, andrew@dunslane.net, robertmhaas@gmail.com, michael@paquier.xyz, tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, mark.dilger@enterprisedb.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Postgres perl module namespace
In-Reply-To: <20210904061949.GA2326091@rfd.leadboat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox