From: Noah Misch <noah@leadboat.com>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Fixing WAL instability in various TAP tests
Date: Sat, 25 Sep 2021 09:00:39 -0700
Message-ID: <20210925160039.GA4134968@rfd.leadboat.com> (raw)
In-Reply-To: <2B4C64CF-EE3F-474B-9685-6A927E5E49AE@enterprisedb.com>
References: <32A1FDD1-9C7B-43B1-B3EE-49198DD3F887@enterprisedb.com>
<20210925052151.GA4082552@rfd.leadboat.com>
<2E9D28A3-1B54-446B-AC12-3BF86A2B522A@enterprisedb.com>
<2502590.1632579467@sss.pgh.pa.us>
<2B4C64CF-EE3F-474B-9685-6A927E5E49AE@enterprisedb.com>
On Sat, Sep 25, 2021 at 08:20:06AM -0700, Mark Dilger wrote:
> > On Sep 25, 2021, at 7:17 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >> Leaving the tests brittle wastes developer time.
> >
> > Trying to make them proof against all possible settings would waste
> > a lot more time, though.
>
> You may be right, but the conversation about "all possible settings" was
> started by Noah.
You wrote, "I would expect tests which fail under legal alternate GUC settings
to be hardened to explicitly set the GUCs as they need, rather than implicitly
relying on the defaults." I read that as raising the general principle, not
just a narrow argument about max_wal_size. We can discontinue talking about
the general principle and focus on max_wal_size.
> I was really just talking about tests that depend on wal
> files not being removed, but taking no action to guarantee that, merely
> trusting that under default settings they won't be.
As I said, +1 for making tests pass under the min_val of max_wal_size. If you
want to introduce a max_wal_size=2 buildfarm member so it stays that way, +1
for that as well.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: noah@leadboat.com, mark.dilger@enterprisedb.com, tgl@sss.pgh.pa.us
Subject: Re: Fixing WAL instability in various TAP tests
In-Reply-To: <20210925160039.GA4134968@rfd.leadboat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox