From: Justin Pryzby <pryzby@telsasoft.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Nitin Jadhav <nitinjadhavpostgres@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: when the startup process doesn't (logging startup delays)
Date: Wed, 29 Sep 2021 12:45:30 -0500
Message-ID: <20210929174530.GK831@telsasoft.com> (raw)
In-Reply-To: <202109291736.w3lzq4prep3p@alvherre.pgsql>
References: <CAMm1aWae1qaxQC+83VZd0NVpzO==n3cxMoqedZvU=TWpmo-uSg@mail.gmail.com>
<202109291736.w3lzq4prep3p@alvherre.pgsql>
On Wed, Sep 29, 2021 at 02:36:14PM -0300, Alvaro Herrera wrote:
> Why is it that we set the next timeout to fire not at "now + interval"
> but at "when-it-should-have-fired-but-didn't + interval"? As a user, if
> I request a message to be logged every N milliseconds, and one
> of them is a little bit delayed, then (assuming I set it to 10s) I still
> expect the next one to occur at now+10s. I don't expect the next at
> "now+5s" if one is delayed 5s.
>
> In other words, I think this function should just be
> enable_timeout_after(STARTUP_PROGRESS_TIMEOUT, log_startup_progress_interval);
>
> This means you can remove the scheduled_startup_progress_timeout
> variable.
Robert requested the current behavior here.
https://www.postgresql.org/message-id/CA%2BTgmoYkS1ZeWdSMFMBecMNxWonHk6J5eoX4FEQrpKtvEbXqGQ%40mail.g...
It's confusing (at least) to get these kind of requests to change the behavior
back and forth.
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, alvherre@alvh.no-ip.org, nitinjadhavpostgres@gmail.com, robertmhaas@gmail.com, michael@paquier.xyz, bharath.rupireddyforpostgres@gmail.com, tgl@sss.pgh.pa.us, andres@anarazel.de, sfrost@snowman.net, magnus@hagander.net, thomas.munro@gmail.com
Subject: Re: when the startup process doesn't (logging startup delays)
In-Reply-To: <20210929174530.GK831@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox