From: Justin Pryzby <pryzby@telsasoft.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Smith <smithpb2250@gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: strange case of "if ((a & b))"
Date: Wed, 6 Oct 2021 21:44:30 -0500
Message-ID: <20211007024430.GM27491@telsasoft.com> (raw)
In-Reply-To: <CAD21AoCdF8dnUvr-BUWWGvA_XhKSoANacBMZb6jKyCk4TYfQ2Q@mail.gmail.com>
References: <20210906001110.GF26465@telsasoft.com>
<YTb/3iLjBg0Te6hI@paquier.xyz>
<YTmNhnRFkT/KjDQ+@paquier.xyz>
<20210909.141450.11969674682374713.horikyota.ntt@gmail.com>
<YTxCKyFgrxQ1tF0P@paquier.xyz>
<CAD21AoCdF8dnUvr-BUWWGvA_XhKSoANacBMZb6jKyCk4TYfQ2Q@mail.gmail.com>
On Thu, Oct 07, 2021 at 11:18:24AM +0900, Masahiko Sawada wrote:
> On Sat, Sep 11, 2021 at 2:44 PM Michael Paquier <michael@paquier.xyz> wrote:
> >
> > On Thu, Sep 09, 2021 at 02:14:50PM +0900, Kyotaro Horiguchi wrote:
> > > Maybe I'm missing something, but I can see several instances of the
> > > "eval-bool ? true : false" pattern after fd0625c7a9 that are not in
> > > the latest 0002.
> >
> > Yep. There are more of these, and I have just looked at some of them
> > as of the patches proposed. What was sent looked clean enough to
> > progress a bit and be done with it.
>
> While reading the decode.c I found the extra parentheses and arrived
> at this thread.
I'm not quite sure how you managed to search for it - well done ;)
> The discussion seems to get inactive now but one (0001
> patch) out of two patches Justin proposed [1] is not committed yet and
> there seems no CF entry for this item (0002 patch already got
> committed, fd0625c7a9). 0001 patch can be cleanly applied and looks
> good to me.
Note that I also included it here:
https://www.postgresql.org/message-id/20210924215827.GS831@telsasoft.com
Michael seems prefer writing (() != 0) in more cases than other people, so
didn't care for that patch.
https://www.postgresql.org/message-id/577206.1620628321@sss.pgh.pa.us
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, sawada.mshk@gmail.com, michael@paquier.xyz, horikyota.ntt@gmail.com, tgl@sss.pgh.pa.us, smithpb2250@gmail.com, bruce@momjian.us, pgsql-hackers@lists.postgresql.org
Subject: Re: strange case of "if ((a & b))"
In-Reply-To: <20211007024430.GM27491@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox