agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Andres Freund <andres@anarazel.de>
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Subject: Re: Adding CI to our tree
Date: Fri, 19 Nov 2021 15:02:04 -0800
Message-ID: <20211119230204.b3klir5guspukiol@alap3.anarazel.de> (raw)
In-Reply-To: <CAAKRu_bBCzU-WWKJw2TBWixnV+LU6h8jDF_XuVk+HfxPvMnmbg@mail.gmail.com>
References: <20211001222752.wrz7erzh4cajvgp6@alap3.anarazel.de>
<20211101055720.7mzwtkhzxmorpxth@alap3.anarazel.de>
<CAAKRu_bBCzU-WWKJw2TBWixnV+LU6h8jDF_XuVk+HfxPvMnmbg@mail.gmail.com>
Hi,
On 2021-11-19 17:17:44 -0500, Melanie Plageman wrote:
> For the README, I found the instructions very clear. My only concern is
> that the cirrus-ci UI will change and the instructions on how to enable
> cirrus-ci on a repository will not be accessible in the same way in the
> future.
I think we can just adjust things at that point, I'm not too worried about
past instructions not working.
> I have attached a patch which does a small refactor using a yaml anchor
> and aliases (tried it and it seems to work for me).
Oh, neat. Yaml is so weird.
> - Would you find it valuable to set a few more coredump_filter bits?
> Might be worth setting bits 2 and 3 (see [2])-- in addition to the
> defaults (on Linux -- I don't know what the equivalent is on other
> platforms).
I don't think we need 2/3 - we don't have file backed mappings. In some
situations setting bit 6 (shared huge pages) would make sense - but here we
don't configure them...
> - I found this line a bit confusing, so maybe it is worth a comment
> sysinfo_script:
> - export || true
We can probably just get rid of the ||. It was just so that a missing 'export'
builtin didn't cause execution to abort. But that won't randomly vanish, so
it's fine.
> - For the docker files, I think it is recommended to run "docker build"
> only from within the specific build context (not in the top-level
> directory), so I don't think you should need the dockerignore file.
We don't have control over that in this case - it's cirrus invoking docker,
and it just uses the whole repo as the context.
> - In ci/docker/linux_debian_bullseye, you can make this change:
> - apt-get clean
> + apt-get clean && \
> + rm -f /var/lib/apt/lists/*
Might not matter too much compared to the size of the whole thing, but it
definitely won't hurt...
Greetings,
Andres Freund
view thread (142+ messages) latest in thread
Message-ID: <20211119230204.b3klir5guspukiol@alap3.anarazel.de>
Permalink: ../20211119230204.b3klir5guspukiol@alap3.anarazel.de/
Also on: postgresql.org/message-id/20211119230204.b3klir5guspukiol@alap3.anarazel.de
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andres@anarazel.de, melanieplageman@gmail.com, thomas.munro@gmail.com, andrew@dunslane.net
Subject: Re: Adding CI to our tree
In-Reply-To: <20211119230204.b3klir5guspukiol@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox