From: Justin Pryzby <pryzby@telsasoft.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: houzj.fnst@fujitsu.com <houzj.fnst@fujitsu.com>
Cc: Rahila Syed <rahilasyed90@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Column Filtering in Logical Replication
Date: Mon, 3 Jan 2022 08:40:57 -0600
Message-ID: <20220103144056.GB24477@telsasoft.com> (raw)
In-Reply-To: <202201031431.akwhcx6xrusu@alvherre.pgsql>
References: <20211231163227.GV24477@telsasoft.com>
<202201031431.akwhcx6xrusu@alvherre.pgsql>
On Mon, Jan 03, 2022 at 11:31:39AM -0300, Alvaro Herrera wrote:
> > Did the DatumGetBool issue expose a deficiency in testing ?
> > I think the !am_partition path was never being hit.
>
> Hmm, the TAP test creates a subscription that contains both types of
> tables. I tried adding an assert for each case, and they were both hit
> on running the test.
Yes, I know both paths are hit now that it uses GetBool.
What I'm wondering is why tests didn't fail when one path wasn't hit - when it
said am_partition=DatumGetChar(); if (!am_partition){}
I suppose it's because the am_partition=true case correctly handles
nonpartitions.
Maybe the !am_partition case should be removed, and add a comment that
pg_partition_tree(pg_partition_root(%u))) also handles non-partitions.
Or maybe that's inefficient...
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, alvherre@alvh.no-ip.org, tomas.vondra@enterprisedb.com, amit.kapila16@gmail.com, peter.eisentraut@enterprisedb.com, houzj.fnst@fujitsu.com, rahilasyed90@gmail.com, smithpb2250@gmail.com
Subject: Re: Column Filtering in Logical Replication
In-Reply-To: <20220103144056.GB24477@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox