From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: houzj.fnst@fujitsu.com <houzj.fnst@fujitsu.com>
Cc: Rahila Syed <rahilasyed90@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Column Filtering in Logical Replication
Date: Thu, 6 Jan 2022 09:22:54 -0300
Message-ID: <202201061222.2xphgufwsf23@alvherre.pgsql> (raw)
In-Reply-To: <CAA4eK1+f-wsbd5jnpDXE9hS9OfG2_Xb++2R+KZ3VQ3=9RJwThg@mail.gmail.com>
On 2022-Jan-06, Amit Kapila wrote:
> On Mon, Jan 3, 2022 at 8:01 PM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> >
>
> fetch_remote_table_info()
> {
> ..
> + appendStringInfo(&cmd,
> + " SELECT pg_catalog.unnest(prattrs)\n"
> + " FROM pg_catalog.pg_publication p JOIN\n"
> + " pg_catalog.pg_publication_rel pr ON (p.oid = pr.prpubid)\n"
> + " WHERE p.pubname IN (%s) AND\n",
> + publications.data);
> + if (!am_partition)
> + appendStringInfo(&cmd, "prrelid = %u", lrel->remoteid);
> + else
> + appendStringInfo(&cmd,
> + "prrelid IN (SELECT relid\n"
> + " FROM pg_catalog.pg_partition_tree(pg_catalog.pg_partition_root(%u)))",
> + lrel->remoteid);
>
> IIUC, this doesn't deal with cases when some publication has not
> specified table attrs. In those cases, I think it should return all
> attrs?
Hmm, no, the idea here is that the list of columns should be null; the
code that uses this result is supposed to handle a null result to mean
hat all columns are included.
> Also, it is not very clear to me what exactly we want to do
> with partitions?
... Hmm, maybe there is a gap in testing here, I'll check; but the idea
is that we would use the column list of the most immediate ancestor that
has one, if the partition itself doesn't have one. (I see we're missing
a check for "pubviaroot", which should represent an override. Need more
tests here.)
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Uno puede defenderse de los ataques; contra los elogios se esta indefenso"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, amit.kapila16@gmail.com, pryzby@telsasoft.com, tomas.vondra@enterprisedb.com, peter.eisentraut@enterprisedb.com, houzj.fnst@fujitsu.com, rahilasyed90@gmail.com, smithpb2250@gmail.com
Subject: Re: Column Filtering in Logical Replication
In-Reply-To: <202201061222.2xphgufwsf23@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox