From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Ibrar Ahmed <ibrar.ahmad@gmail.com>
Cc: Arne Roland <A.Roland@index.de>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Rahila Syed <rahilasyed90@gmail.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Subject: Re: a misbehavior of partition row movement (?)
Date: Thu, 6 Jan 2022 09:36:31 -0300
Message-ID: <202201061236.bgv32vb7xzir@alvherre.pgsql> (raw)
In-Reply-To: <CA+HiwqEgCZzSTn9MQ4-m8R1BupXfpY6HMfmkDiy5=1i7NvQNKA@mail.gmail.com>
On 2022-Jan-06, Amit Langote wrote:
> On Thu, Jan 6, 2022 at 7:27 AM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> > I have pushed it thinking that we would not backpatch any of this fix.
> > However, after running the tests and realizing that I didn't need an
> > initdb for either patch, I wonder if maybe the whole series *is*
> > backpatchable.
>
> We do lack help from trigger.c in the v12 branch in that there's no
> Trigger.tgisclone, which is used in a couple of places in the fix. I
> haven't checked how big of a deal it would be to back-port
> Trigger.tgisclone to v12, but maybe that's doable.
Yeah, I realized afterwards that we added tgparentid in 13 only
(b9b408c48), so we should only backpatch to that.
> > There is one possible problem, which is that psql and pg_dump would need
> > testing to verify that they work decently (i.e. no crash, no
> > misbehavior) with partitioned tables created with the original code.
>
> I suppose you mean checking if the psql and pg_dump after applying
> *0001* work sanely with partitioned tables defined without 0001?
Yes.
> Will test that.
I looked at the backpatch at the last minute yesterday. The tablecmds.c
conflict is easy to resolve, but the one in pg_dump.c is a giant
conflict zone that I didn't have time to look closely :-(
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, amitlangote09@gmail.com, andrew@dunslane.net, ibrar.ahmad@gmail.com, A.Roland@index.de, david.g.johnston@gmail.com, sawada.mshk@gmail.com, peter.eisentraut@enterprisedb.com, rahilasyed90@gmail.com, tomas.vondra@2ndquadrant.com
Subject: Re: a misbehavior of partition row movement (?)
In-Reply-To: <202201061236.bgv32vb7xzir@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox