From: Justin Pryzby <pryzby@telsasoft.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: houzj.fnst@fujitsu.com, Rahila Syed <rahilasyed90@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Column Filtering in Logical Replication
Date: Tue, 11 Jan 2022 15:10:53 -0600
Message-ID: <20220111211053.GB14051@telsasoft.com> (raw)
In-Reply-To: <202201110028.wicsx7ex2o6a@alvherre.pgsql>
References: <2d6c8b74-bdef-767b-bdb6-29705985ed9c@enterprisedb.com>
<202201110028.wicsx7ex2o6a@alvherre.pgsql>
Is there any coordination between the "column filter" patch and the "row
filter" patch ? Are they both on track for PG15 ? Has anybody run them
together ?
Whichever patch is merged 2nd should include tests involving a subset of
columns along with a WHERE clause.
I have a suggestion: for the functions for which both patches are adding
additional argument types, define a filtering structure for both patches to
use. Similar to what we did for some utility statements in a3dc92600.
I'm referring to:
logicalrep_write_update()
logicalrep_write_tuple()
That would avoid avoid some rebase conflicts on april 9, and avoid functions
with 7,8,9 arguments, and maybe simplify adding arguments in the future.
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, alvherre@alvh.no-ip.org, peter.eisentraut@enterprisedb.com, tomas.vondra@enterprisedb.com, amit.kapila16@gmail.com, rahilasyed90@gmail.com, smithpb2250@gmail.com
Subject: Re: Column Filtering in Logical Replication
In-Reply-To: <20220111211053.GB14051@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox