pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Noah Misch <noah@leadboat.com>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Cc: pgbf@twiska.com, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: XLogReadRecord() error in XlogReadTwoPhaseData()
Date: Sun, 23 Jan 2022 17:17:59 -0800
Message-ID: <20220124011759.GC1131882@rfd.leadboat.com> (raw)
In-Reply-To: <78685FA0-EEC6-4AFB-B323-C37A99C82563@anarazel.de>
References: <2782601.1637189230@sss.pgh.pa.us>
	<20211118070506.GA1294133@rfd.leadboat.com>
	<20211120051823.GA1367142@rfd.leadboat.com>
	<20220116071210.GA735692@rfd.leadboat.com>
	<CA+hUKGLoV=wYa301GWaQUb7zb4cNE4QLqnik_QbHe-=3kpp=Ew@mail.gmail.com>
	<20220116210241.GC756210@rfd.leadboat.com>
	<20220122185241.GA1095169@rfd.leadboat.com>
	<CA+hUKGLbtEfCMXA9H+W6R-FRS7yojs5TdfqbNdEetTa7pB4Khw@mail.gmail.com>
	<20220123232927.GA1131882@rfd.leadboat.com>
	<78685FA0-EEC6-4AFB-B323-C37A99C82563@anarazel.de>

On Sun, Jan 23, 2022 at 05:03:04PM -0800, Andres Freund wrote:
> On January 23, 2022 3:29:27 PM PST
> >(a) Modify the tests so the affected animals can skip affected tests by
> >setting an environment variable, named PG_TEST_HAS_WAL_READ_BUG or similar.
> 
> Why not just detect the problem in the tap test and skip, rather than requiring multiple buildfarm configs to be changed as well as the test itself? 

End users running PostgreSQL test suites to acceptance-test their stack should
consider the affected stack unusable for PostgreSQL.  Hence, I ruled out that
approach, despite having implemented it at one point.  Under some plausible
set of goals, it is optimal.





view thread (35+ messages)  latest in thread

Message-ID: <20220124011759.GC1131882@rfd.leadboat.com>
Permalink:  ../20220124011759.GC1131882@rfd.leadboat.com/
Also on:    postgresql.org/message-id/20220124011759.GC1131882@rfd.leadboat.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: noah@leadboat.com, andres@anarazel.de, thomas.munro@gmail.com, tgl@sss.pgh.pa.us, michael@paquier.xyz
  Subject: Re: XLogReadRecord() error in XlogReadTwoPhaseData()
  In-Reply-To: <20220124011759.GC1131882@rfd.leadboat.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox