pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedFrom: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@lists.postgresql.org, Simon Riggs <simon.riggs@enterprisedb.com>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Zhihong Yu <zyu@yugabyte.com>
Cc: Daniel Westermann <dwe@dbi-services.com>
Cc: Amit Langote <amitlangote09@gmail.com>
Cc: Japin Li <japinli@hotmail.com>
Cc: Erik Rijkers <er@xs4all.nl>
Cc: Jaime Casanova <jcasanov@systemguards.com.ec>
Subject: Re: support for MERGE
Date: Fri, 11 Feb 2022 15:21:43 -0300
Message-ID: <202202111821.w3gqblvfp4pr@alvherre.pgsql> (raw)
In-Reply-To: <20220128231948.GI23027@telsasoft.com>
On 2022-Jan-28, Justin Pryzby wrote:
> Have you looked at code coverage ? I have an experimental patch to add that to
> cirrus, and ran it with this patch; visible here:
> https://cirrus-ci.com/task/6362512059793408
Ah, thanks, this is useful. I think it is showing that the new code is
generally well covered, but there are some exceptions, particularly
ExecMergeMatched in some concurrent cases (TM_Deleted and
TM_SelfModified after table_tuple_lock -- those code pages have
user-facing errors but are not covered by any tests.)
How does this work? I notice it is reporting for
src/bin/pg_upgrade/relfilenode.c, but that file is not changed by this
patch.
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
view thread (123+ messages) latest in thread
Message-ID: <202202111821.w3gqblvfp4pr@alvherre.pgsql>
Permalink: ../202202111821.w3gqblvfp4pr@alvherre.pgsql/
Also on: postgresql.org/message-id/202202111821.w3gqblvfp4pr@alvherre.pgsql
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, pryzby@telsasoft.com, simon.riggs@enterprisedb.com, tomas.vondra@enterprisedb.com, zyu@yugabyte.com, dwe@dbi-services.com, amitlangote09@gmail.com, japinli@hotmail.com, er@xs4all.nl, jcasanov@systemguards.com.ec
Subject: Re: support for MERGE
In-Reply-To: <202202111821.w3gqblvfp4pr@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox