From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Shinoda, Noriyoshi (PN Japan FSIP) <noriyoshi.shinoda@hpe.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Jeevan Ladhe <jeevanladhe.os@gmail.com>
Cc: Dipesh Pandit <dipesh.pandit@gmail.com>
Cc: Abhijit Menon-Sen <ams@toroid.org>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: tushar <tushar.ahuja@enterprisedb.com>
Subject: Re: refactoring basebackup.c
Date: Wed, 16 Feb 2022 13:11:31 -0300
Message-ID: <202202161611.kvj7zsvvue5v@alvherre.pgsql> (raw)
In-Reply-To: <CA+TgmoZeUPgY3TJZMuiFQyFfzpZEtQhjTU2UaKirD_E4Gk_2sQ@mail.gmail.com>
On 2022-Feb-14, Robert Haas wrote:
> A more consistent way of writing the supported syntax would be like this:
>
> -Z, --compress={[{client|server}-]{gzip|lz4}}[:LEVEL]|LEVEL|none}
>
> I would be somewhat inclined to leave the level-only variant
> undocumented and instead write it like this:
>
> -Z, --compress={[{client|server}-]{gzip|lz4}}[:LEVEL]|none}
This is hard to interpret for humans though because of the nested
brackets and braces. It gets considerably easier if you split it in
separate variants:
-Z, --compress=[{client|server}-]{gzip|lz4}[:LEVEL]
-Z, --compress=LEVEL
-Z, --compress=none
compress tar output with given compression method or level
or, if you choose to leave the level-only variant undocumented, then
-Z, --compress=[{client|server}-]{gzip|lz4}[:LEVEL]
-Z, --compress=none
compress tar output with given compression method or level
There still are some nested brackets and braces, but the scope is
reduced enough that interpreting seems quite a bit simpler.
--
Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, robertmhaas@gmail.com, noriyoshi.shinoda@hpe.com, pryzby@telsasoft.com, jeevanladhe.os@gmail.com, dipesh.pandit@gmail.com, ams@toroid.org, 9erthalion6@gmail.com, jeevan.ladhe@enterprisedb.com, mark.dilger@enterprisedb.com, tushar.ahuja@enterprisedb.com
Subject: Re: refactoring basebackup.c
In-Reply-To: <202202161611.kvj7zsvvue5v@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox