public inbox for [email protected]
help / color / mirror / Atom feedFrom: KAWAMOTO Masaya <[email protected]>
To: Tatsuo Ishii <[email protected]>
Cc: [email protected]
Subject: Re: Typo in pgbench messages.
Date: Thu, 24 Feb 2022 14:00:26 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
Thanks for your comment!
Sorry, I did not attach the patch file.
This patch focas on master branch.
Best regards,
On Thu, 24 Feb 2022 12:15:55 +0900 (JST)
Tatsuo Ishii <[email protected]> wrote:
> > Hi,
> >
> > I found messages inserted a space before the "%" in pgbench.
> > I think this is typo because there are no space before the "%" in other messages.
> > What do you think?
>
> I think you are right. In English there's should be no space between number and "%".
> AFAIK other parts of PostgreSQL follow the rule.
>
> > diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
> > index f166a77e3a..4ebe5e6ea4 100644
> > --- a/src/bin/pgbench/pgbench.c
> > +++ b/src/bin/pgbench/pgbench.c
> > @@ -5598,11 +5598,11 @@ printResults(StatsData *total,
> > return;
> >
> > if (throttle_delay && latency_limit)
> > - printf("number of transactions skipped: " INT64_FORMAT " (%.3f %%)\n",
> > + printf("number of transactions skipped: " INT64_FORMAT " (%.3f%%)\n",
> > total->skipped, 100.0 * total->skipped / total->cnt);
> >
> > if (latency_limit)
> > - printf("number of transactions above the %.1f ms latency limit: " INT64_FORMAT "/" INT64_FORMAT " (%.3f %%)\n",
> > + printf("number of transactions above the %.1f ms latency limit: " INT64_FORMAT "/" INT64_FORMAT " (%.3f%%)\n",
> > latency_limit / 1000.0, latency_late, ntx,
> > (ntx > 0) ? 100.0 * latency_late / ntx : 0.0);
>
> Looks good to me.
>
> Best reagards,
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese:http://www.sraoss.co.jp
>
>
--
KAWAMOTO Masaya <[email protected]>
SRA OSS, Inc. Japan
Attachments:
[application/octet-stream] typo_in_pgbench_messages.patch (840B, ../[email protected]/2-typo_in_pgbench_messages.patch)
download | inline diff:
diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
index f166a77e3a..4ebe5e6ea4 100644
--- a/src/bin/pgbench/pgbench.c
+++ b/src/bin/pgbench/pgbench.c
@@ -5598,11 +5598,11 @@ printResults(StatsData *total,
return;
if (throttle_delay && latency_limit)
- printf("number of transactions skipped: " INT64_FORMAT " (%.3f %%)\n",
+ printf("number of transactions skipped: " INT64_FORMAT " (%.3f%%)\n",
total->skipped, 100.0 * total->skipped / total->cnt);
if (latency_limit)
- printf("number of transactions above the %.1f ms latency limit: " INT64_FORMAT "/" INT64_FORMAT " (%.3f %%)\n",
+ printf("number of transactions above the %.1f ms latency limit: " INT64_FORMAT "/" INT64_FORMAT " (%.3f%%)\n",
latency_limit / 1000.0, latency_late, ntx,
(ntx > 0) ? 100.0 * latency_late / ntx : 0.0);
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Typo in pgbench messages.
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox