agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Justin Pryzby <pryzby@telsasoft.com>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-hackers@postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Cc: Melanie Plageman <melanieplageman@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Subject: Re: Adding CI to our tree
Date: Sat, 26 Feb 2022 20:43:52 -0600
Message-ID: <20220227024352.GC25269@telsasoft.com> (raw)
In-Reply-To: <20220227010908.vz2a7dmfzgwg742w@alap3.anarazel.de>
References: <20220203035827.GG23027@telsasoft.com>
<20220203195718.smqo5xg4ygp5qktq@alap3.anarazel.de>
<20220204050403.GL23027@telsasoft.com>
<20220206032339.tuyo534rfbvu4mbh@alap3.anarazel.de>
<20220212220640.GL31460@telsasoft.com>
<20220212222625.aph3ft466ntifrpi@alap3.anarazel.de>
<20220213214213.GS31460@telsasoft.com>
<20220213220709.vjz5rziuhfdpqxrg@alap3.anarazel.de>
<20220226025116.GJ9008@telsasoft.com>
<20220227010908.vz2a7dmfzgwg742w@alap3.anarazel.de>
On Sat, Feb 26, 2022 at 05:09:08PM -0800, Andres Freund wrote:
> > XXX: if this is run in the same task, the configure flags should probably be
> > consistent ?
>
> What do you mean?
I mean that commit to run CompilerWarnings unconditionally built docs with
different flags than the other stuff in that task. If it's going to be a
separate task, then that doesn't matter.
> > +# Verify docs can be built, and upload changed docs as artifacts
> > +task:
> > + name: HTML docs
> > +
> > + env:
> > + CPUS: 1
> > +
> > + only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:[^\n]*(docs|html).*'
> > +
> > + container:
> > + image: $CONTAINER_REPO/linux_debian_bullseye_ci:latest
> > + cpu: $CPUS
> > +
>
> how about using something like (the syntax might be slightly off)
> skip: !changesInclude('doc/**')
> to avoid running it for the many pushes where no docs are changed?
This doesn't do the right thing - I just tried.
https://cirrus-ci.org/guide/writing-tasks/#environment-variables
| changesInclude function can be very useful for skipping some tasks when no changes to sources have been made since the last successful Cirrus CI build.
That means it will not normally rebuild docs (and then this still requires
resolving the "base branch").
--
Justin
view thread (142+ messages) latest in thread
Message-ID: <20220227024352.GC25269@telsasoft.com>
Permalink: ../20220227024352.GC25269@telsasoft.com/
Also on: postgresql.org/message-id/20220227024352.GC25269@telsasoft.com
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, andres@anarazel.de, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, andrew@dunslane.net, thomas.munro@gmail.com, melanieplageman@gmail.com, peter.eisentraut@enterprisedb.com, daniel@yesql.se
Subject: Re: Adding CI to our tree
In-Reply-To: <20220227024352.GC25269@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox