public inbox for [email protected]
help / color / mirror / Atom feedFrom: Nathan Bossart <[email protected]>
To: Bharath Rupireddy <[email protected]>
Cc: Cary Huang <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: add checkpoint stats of snapshot and mapping files of pg_logical dir
Date: Fri, 11 Mar 2022 12:05:11 -0800
Message-ID: <20220311200511.GA682814@nathanxps13> (raw)
In-Reply-To: <CALj2ACXx9rCRP7RiLKDgh76oUqdsifjeNRGqmgxDmh8K8X85SA@mail.gmail.com>
References: <CALj2ACXwALpiPyqj8n-LLB8J_R_s9pE3xvuGJWjVEBngG6873Q@mail.gmail.com>
<163823361875.8893.16011115215407536326.pgcf@coridan.postgresql.org>
<CALj2ACXx9rCRP7RiLKDgh76oUqdsifjeNRGqmgxDmh8K8X85SA@mail.gmail.com>
+ CheckpointStats.repl_map_cutoff_lsn = cutoff;
Could we set repl_map_cutoff_lsn closer to where it is calculated? Right
now, it's set at the bottom of the function just before the directory is
freed. Is there a strong reason to do it there?
+ "logical rewrite mapping file(s) removed/synced=" UINT64_FORMAT ", size=%zu bytes, time=%ld.%03d s, cutoff LSN=%X/%X",
Can we split out the "removed" versus "synced" files? Otherwise, I think
this is basically just telling us how many files are in the mappings
directory.
+ CheckpointStats.repl_snap_cutoff_lsn = cutoff;
I have the same note for this one as I have for repl_map_cutoff_lsn.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: add checkpoint stats of snapshot and mapping files of pg_logical dir
In-Reply-To: <20220311200511.GA682814@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox