From: Julien Rouhaud <rjuju123@gmail.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: remove reset_shared()
Date: Wed, 30 Mar 2022 09:19:42 +0800
Message-ID: <20220330011942.fpouca2laocok7ng@jrouhaud> (raw)
In-Reply-To: <20220329221702.GA559657@nathanxps13>
References: <20220329221702.GA559657@nathanxps13>
Hi,
On Tue, Mar 29, 2022 at 03:17:02PM -0700, Nathan Bossart wrote:
> Hi hackers,
>
> Is there any reason to keep reset_shared() around anymore? It is now just
> a wrapper function for CreateSharedMemoryAndSemaphores(), and AFAICT the
> information in the comments is already covered by comments in the shared
> memory code. I think it's arguable that the name of the function makes it
> clear that it might recreate the shared memory, but if that is a concern,
> perhaps we could rename the function to something like
> CreateOrRecreateSharedMemoryAndSemaphores().
>
> I've attached a patch that simply removes this wrapper function. This is
> admittedly just nitpicking, so I don't intend to carry this patch further
> if anyone is opposed.
I'm +0.5 for it, it doesn't bring much and makes things a bit harder to
understand, as you need to go through an extra function.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: rjuju123@gmail.com, nathandbossart@gmail.com
Subject: Re: remove reset_shared()
In-Reply-To: <20220330011942.fpouca2laocok7ng@jrouhaud>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox