agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Justin Pryzby <pryzby@telsasoft.com>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Joel Jacobson <joel@compiler.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Schema variables - new implementation for Postgres 15+1
Date: Sun, 10 Apr 2022 15:43:33 -0500
Message-ID: <20220410204333.GA26620@telsasoft.com> (raw)
In-Reply-To: <CAFj8pRCeu_Aku3mHqS6vDL1p02u1Ed5QiOGL3e4CPKyvkW6s3Q@mail.gmail.com>
References: <CAFj8pRCZ9fVAC6h-s8fHS9muXmPwvHcwAX3omRJm9vUaQTMUcA@mail.gmail.com>
<20220129051946.outrihp7phagjeey@jrouhaud>
<CAFj8pRDbH4vpP5BTieD4Mw5OtdoLBb0ucqZhYB5c1SFPcqVoxg@mail.gmail.com>
<CAFj8pRCzVU8DHZmRChJot5OJfkMMg_8PWXz5k5u+YT=BkfCVrA@mail.gmail.com>
<20220202140852.7wivednqmjp7nibf@jrouhaud>
<CAFj8pRC6Lqn+jXManUO3+qsgjvevQiABhsM1CUTo+z+C_BoLYA@mail.gmail.com>
<CAFj8pRAoDDDCt1W6jJOGjnfjSYzs_Ei9dN4=RDE+mcVq9hJOhw@mail.gmail.com>
<20220303070652.xjmyd6xkeqfazvjh@jrouhaud>
<20220303071626.c3ok2qz7s2rya25l@jrouhaud>
<CAFj8pRCeu_Aku3mHqS6vDL1p02u1Ed5QiOGL3e4CPKyvkW6s3Q@mail.gmail.com>
On Sun, Apr 10, 2022 at 08:30:39PM +0200, Pavel Stehule wrote:
> I am sending fresh rebased patch + separation to more patches. This split
> is initial, and can be changed later
The 0001 patch requires this, but it's not included until 0003.
src/include/commands/session_variable.h
Each patch should compile and pass tests with the preceding patches, without
the following patches. I think the regression tests should be included with
their corresponding patch. Maybe it's ok to separate out the changes for
pg_dump, docs, and psql - but they'd have to be merged together eventually.
I realize some of this runs counter to Julien's suggestion to split patches.
The version should be changed:
+ if (fout->remoteVersion < 150000)
I enabled these, which causes the regression tests fail:
+#define COPY_PARSE_PLAN_TREES
+#define WRITE_READ_PARSE_PLAN_TREES
+#define RAW_EXPRESSION_COVERAGE_TEST
/home/pryzbyj/src/postgres/src/test/regress/results/session_variables.out 2022-04-10 15:37:32.926306124 -0500
@@ -16,7 +16,7 @@
SET ROLE TO var_test_role;
-- should fail
LET var1 = 10;
-ERROR: permission denied for session variable var1
+ERROR: unrecognized node type: 368
...
view thread (365+ messages) latest in thread
Message-ID: <20220410204333.GA26620@telsasoft.com>
Permalink: ../20220410204333.GA26620@telsasoft.com/
Also on: postgresql.org/message-id/20220410204333.GA26620@telsasoft.com
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, pavel.stehule@gmail.com, rjuju123@gmail.com, dean.a.rasheed@gmail.com, joel@compiler.org, pgsql-hackers@lists.postgresql.org
Subject: Re: Schema variables - new implementation for Postgres 15+1
In-Reply-To: <20220410204333.GA26620@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox