public inbox for [email protected]
help / color / mirror / Atom feedFrom: Justin Pryzby <[email protected]>
To: Andres Freund <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: Himanshu Upadhyaya <[email protected]>
Cc: Nikita Glukhov <[email protected]>
Cc: [email protected]
Cc: Dmitry Dolgov <[email protected]>
Cc: Oleg Bartunov <[email protected]>
Cc: Erik Rijkers <[email protected]>
Subject: cirrus: run macos with COPY_PARSE_PLAN_TREES etc
Date: Wed, 27 Apr 2022 09:53:58 -0500
Message-ID: <[email protected]> (raw)
fork: <[email protected]>
On Thu, Mar 24, 2022 at 05:09:33PM -0700, Andres Freund wrote:
> On 2022-03-24 18:51:30 -0400, Andrew Dunstan wrote:
> > I wonder if we should add these compile flags to the cfbot's setup?
>
> Yes, I think we should. There's a bit of discussion of that in and below
> https://postgr.es/m/20220213051937.GO31460%40telsasoft.com - that veered a bit
> of course, so I haven't done anything about it yet. Perhaps one build
> COPY_PARSE_PLAN_TREES and RAW_EXPRESSION_COVERAGE_TEST another
> WRITE_READ_PARSE_PLAN_TREES? We should add the slower to the macos build,
> that's plenty fast and I'm intending to slow the linux test by using ubsan,
> which works better on linux.
Why would you put them on different tasks ?
to avoid slowing down one task too much ?
That doesn't seem to be an issue, at least for those three defines.
What about adding RELCACHE_FORCE_RELEASE, too ?
Even with that, macos is only ~1min slower.
https://cirrus-ci.com/task/5456727205216256
commit 53480b8db63b5cd2476142e28ed3f9fe8480f9f3
Author: Justin Pryzby <[email protected]>
Date: Thu Apr 14 06:27:07 2022 -0500
cirrus/macos: enable various runtime checks
cirrus CI can take a while to be schedule on macos, but the instance always has
many cores, so this is a good platform to enable options which will slow it
down.
See:
https://www.postgresql.org/message-id/[email protected]
https://www.postgresql.org/message-id/20211213211223.vkgg3wwiss2tragj%40alap3.anarazel.de
https://www.postgresql.org/message-id/CAH2-WzmevBhKNEtqX3N-Tkb0gVBHH62C0KfeTxXzqYES_PiFiA%40mail.gma...
https://www.postgresql.org/message-id/[email protected]
ci-os-only: macos
diff --git a/.cirrus.yml b/.cirrus.yml
index e0264929c74..4a6511115fc 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -337,6 +337,7 @@ task:
CLANG="ccache ${brewpath}/llvm/bin/ccache" \
CFLAGS="-Og -ggdb" \
CXXFLAGS="-Og -ggdb" \
+ CPPFLAGS="-DRELCACHE_FORCE_RELEASE -DCOPY_PARSE_PLAN_TREES -DWRITE_READ_PARSE_PLAN_TREES -DRAW_EXPRESSION_COVERAGE_TEST" \
\
LLVM_CONFIG=${brewpath}/llvm/bin/llvm-config \
PYTHON=python3
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: cirrus: run macos with COPY_PARSE_PLAN_TREES etc
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox