pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Nathan Bossart <nathandbossart@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Ian Lawrence Barwick <barwick@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: docs: mention "pg_read_all_stats" in "track_activities" description
Date: Sat, 21 May 2022 11:57:43 -0700
Message-ID: <20220521185743.GA886636@nathanxps13> (raw)
In-Reply-To: <YohcelRv74nuHC9Z@paquier.xyz>
References: <CAB8KJ=jhPyYFu-A5r-ZGP+Ax715mUKsMxAGcEQ9Cx_mBAmrPow@mail.gmail.com>
	<20220520230837.GB877934@nathanxps13>
	<YohcelRv74nuHC9Z@paquier.xyz>

On Sat, May 21, 2022 at 12:28:58PM +0900, Michael Paquier wrote:
> Indeed, it is a good idea to add this information.  Will apply and
> backpatch accordingly.

Sorry, I should've noticed this yesterday.  This should probably follow
6198420's example and say "roles with privileges of the pg_read_all_stats
role" instead of "members of the pg_read_all_stats role."  Also, I think we
should mention that this information is visible to roles with privileges of
the session user being reported on, too.  Patch attached.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Attachments:

read_all_stats_fix.patch (text/x-diff, 1.2K) download
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index fe64239ed9..a91145ccf3 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -7917,11 +7917,11 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv;
         executing command of each session, along with its identifier and the
         time when that command began execution. This parameter is on by
         default. Note that even when enabled, this information is only
-        visible to superusers, members of the
-        <literal>pg_read_all_stats</literal> role and the user owning the
-        session being reported on, so it should not represent a security risk.
-        Only superusers and users with the appropriate <literal>SET</literal>
-        privilege can change this setting.
+        visible to superusers, roles with privileges of the
+        <literal>pg_read_all_stats</literal> role, and roles with privileges of
+        the user owning the session being reported on, so it should not
+        represent a security risk. Only superusers and users with the
+        appropriate <literal>SET</literal> privilege can change this setting.
        </para>
       </listitem>
      </varlistentry>

view thread (14+ messages)  latest in thread

Message-ID: <20220521185743.GA886636@nathanxps13>
Permalink:  ../20220521185743.GA886636@nathanxps13/
Also on:    postgresql.org/message-id/20220521185743.GA886636@nathanxps13

copy link · copy postgr.es · copy git am

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, michael@paquier.xyz, barwick@gmail.com
  Subject: Re: docs: mention "pg_read_all_stats" in "track_activities" description
  In-Reply-To: <20220521185743.GA886636@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox