public inbox for [email protected]  
help / color / mirror / Atom feed
From: Kyotaro Horiguchi <[email protected]>
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: fix stats_fetch_consistency value in postgresql.conf.sample
Date: Thu, 26 May 2022 16:27:53 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>

At Thu, 26 May 2022 13:00:45 +0900 (JST), Kyotaro Horiguchi <[email protected]> wrote in 
> At Wed, 25 May 2022 21:25:53 -0500, Justin Pryzby <[email protected]> wrote in 
> > And I think these should be updated it postgresql.conf to use the same unit as
> > in current_setting().
> > 
> >  track_activity_query_size   | 1kB                                                                      | 1024
> >  wal_buffers                 | 4MB                                                                      | -1
> >  wal_receiver_timeout        | 1min                                                                     | 60s
> >  wal_sender_timeout          | 1min                                                                     | 60s
> 
> I'm not sure we should do so.  Rather I'd prefer 60s than 1min here.

It could be in SQL, but *I* prefer to use perl for this, since it
allows me to write a bit complex things (than simple string
comparison) simpler.

So the attached is a wip version of that

Numeric values are compared considering units. But does not require
the units of the both values to match.  Some variables are ignored by
an explicit instruction (ignored_parameters).  Some variables are
compared case-insensitively by an explicit instruction
(case_insensitive_params).  bool and enum are compared
case-insensitively automatically.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center


view thread (42+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: fix stats_fetch_consistency value in postgresql.conf.sample
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox