From: Nathan Bossart <nathandbossart@gmail.com>
To: Shinya Kato <Shinya11.Kato@oss.nttdata.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: przemyslaw@sztoch.pl
Cc: david.g.johnston@gmail.com
Cc: robertmhaas@gmail.com
Cc: daniel@yesql.se
Cc: pgsql-hackers@postgresql.org
Subject: Re: Add --{no-,}bypassrls flags to createuser
Date: Thu, 26 May 2022 09:20:37 -0700
Message-ID: <20220526162037.GA1345023@nathanxps13> (raw)
In-Reply-To: <6a25c0fec85c61c0bb93ab4819fdd619@oss.nttdata.com>
References: <Yow+PeCg1bwi63ay@paquier.xyz>
<0738cb3a8a52e850dd17a0065f2d8e5b@oss.nttdata.com>
<20220524170910.GA1190535@nathanxps13>
<20220525.110752.305692011781436338.horikyota.ntt@gmail.com>
<Yo2m7Oip47raXzfT@paquier.xyz>
<6a25c0fec85c61c0bb93ab4819fdd619@oss.nttdata.com>
On Thu, May 26, 2022 at 02:16:37PM +0900, Shinya Kato wrote:
> On 2022-05-25 11:07, Kyotaro Horiguchi wrote:
>> At Tue, 24 May 2022 10:09:10 -0700, Nathan Bossart
>> <nathandbossart@gmail.com> wrote in
>> > We're still missing some "fancier" string patterns in the tests, but
>> > we
>> > might just be nitpicking at this point.
>>
>> Such "fancier" strings should be properly handled by FmtId() and
>> appendStringLiteralConn. If this is a privilege escalating command,
>> we should have ones but this is not.
>
> Sorry, I didn't quite understand the "fancier" pattern. Is a string like
> this patch correct?
Yes, thanks. I'm marking this as ready-for-committer.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, Shinya11.Kato@oss.nttdata.com, michael@paquier.xyz, horikyota.ntt@gmail.com, przemyslaw@sztoch.pl, david.g.johnston@gmail.com, robertmhaas@gmail.com, daniel@yesql.se
Subject: Re: Add --{no-,}bypassrls flags to createuser
In-Reply-To: <20220526162037.GA1345023@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox