public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andres Freund <[email protected]>
To: Aleksander Alekseev <[email protected]>
Cc: PostgreSQL Development <[email protected]>
Cc: Tom Lane <[email protected]>
Subject: Re: [RFC] building postgres with meson
Date: Thu, 2 Jun 2022 08:22:57 -0700
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAJ7c6TMu0xGZUR419LSQCk=w230Q4eRCxqFx50RRWjKpFz5SSA@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<CAJ7c6TOCOvPsOm5azM1cgxz8=tDcf9bWhjw0DoDp1G=X4ai3=w@mail.gmail.com>
	<[email protected]>
	<CAJ7c6TMgZ5_sQ9tmFeu1NZjcMD5PuoyGqJ2TyUV3ZethmEyi=w@mail.gmail.com>
	<[email protected]>
	<CAJ7c6TPpbwdD4TupMrvjk3o9iF8gcgZbq3q+qNGomB5qmMMGGw@mail.gmail.com>
	<[email protected]>
	<CAJ7c6TMu0xGZUR419LSQCk=w230Q4eRCxqFx50RRWjKpFz5SSA@mail.gmail.com>

Hi,

On 2022-06-02 15:34:23 +0300, Aleksander Alekseev wrote:
> Hi Andres,
> 
> > Cool. I think I pushed a fix/workaround for the issue now. Still can't decide
> > whether it's apple's or meson's fault.
> 
> Many thanks! The fix solved the problem, I can compile with -Dldap=enabled now.
> The code passes the tests too.

Cool.


> > I suspect the errors might be due to CC/CPPFLAGS/... not being defined. I can
> > try to make it output something roughly compatible with the old output, for
> > most of those I already started to compute values for the PGXS compat stuff I
> > was hacking on recently.
> 
> Yes, that could explain the problem. Just for the record, I get several errors
> regarding src/export.h in TimescaleDB code [1]:
> 

I think this is timescale's issue. Why are you defining / undefining
PGDLLEXPORT?

Part of the patch series is to use visibility attributes, and your #if
TS_EMPTY(PGDLLEXPORT) thing can't handle that.

Greetings,

Andres Freund

view thread (129+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [RFC] building postgres with meson
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox