pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jonathan S. Katz <jkatz@postgresql.org>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Christoph Berg <myon@debian.org>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Joe Conway <mail@joeconway.com>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: David Rowley <dgrowleyml@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: How about a psql backslash command to show GUCs?
Date: Mon, 6 Jun 2022 08:55:29 -0500
Message-ID: <20220606135529.GV29853@telsasoft.com> (raw)
In-Reply-To: <807242.1649776780@sss.pgh.pa.us>
References: <4105551.1649514677@sss.pgh.pa.us>
	<YlGtICTMIJ886Ij3@jrouhaud>
	<afad841b-cc31-1784-84f7-b6c3c71d0c5d@postgresql.org>
	<4115803.1649521632@sss.pgh.pa.us>
	<043bcb40-052f-5c85-63ff-d6a2b5a0b7ca@postgresql.org>
	<495595.1649704355@sss.pgh.pa.us>
	<9439380b-a81f-c910-f527-db4d470b026b@postgresql.org>
	<531275.1649707882@sss.pgh.pa.us>
	<7bba5a32-65fe-04e1-7c36-efd963a625c9@postgresql.org>
	<807242.1649776780@sss.pgh.pa.us>

On Tue, Apr 12, 2022 at 11:19:40AM -0400, Tom Lane wrote:
> "Jonathan S. Katz" <jkatz@postgresql.org> writes:
> > On 4/11/22 4:11 PM, Tom Lane wrote:
> >> This idea does somewhat address my unhappiness upthread about printing
> >> values with source = 'internal', but I see that it gets confused by
> >> some GUCs with custom show hooks, like unix_socket_permissions.
> >> Maybe it needs to be "source != 'default' AND setting != boot_val"?
> 
> > Running through a few GUCs, that seems reasonable. Happy to test the 
> > patch out prior to commit to see if it renders better.
> 
> It'd just look like this, I think.  I see from looking at guc.c that
> boot_val can be NULL, so we'd better use IS DISTINCT FROM.

I noticed this is showing "pre-computed" gucs, like:

 shared_memory_size                | 149MB
 shared_memory_size_in_huge_pages  | 75

I'm not opposed to that, but I wonder if that's what's intended / best.

-- 
Justin





view thread (71+ messages)  latest in thread

Message-ID: <20220606135529.GV29853@telsasoft.com>
Permalink:  ../20220606135529.GV29853@telsasoft.com/
Also on:    postgresql.org/message-id/20220606135529.GV29853@telsasoft.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, tgl@sss.pgh.pa.us, jkatz@postgresql.org, rjuju123@gmail.com, myon@debian.org, pavel.stehule@gmail.com, david.g.johnston@gmail.com, mail@joeconway.com, mark.dilger@enterprisedb.com, andrew@dunslane.net, dgrowleyml@gmail.com, alvherre@alvh.no-ip.org
  Subject: Re: How about a psql backslash command to show GUCs?
  In-Reply-To: <20220606135529.GV29853@telsasoft.com>
  References: <4105551.1649514677@sss.pgh.pa.us> <YlGtICTMIJ886Ij3@jrouhaud> <afad841b-cc31-1784-84f7-b6c3c71d0c5d@postgresql.org> <4115803.1649521632@sss.pgh.pa.us> <043bcb40-052f-5c85-63ff-d6a2b5a0b7ca@postgresql.org> <495595.1649704355@sss.pgh.pa.us> <9439380b-a81f-c910-f527-db4d470b026b@postgresql.org> <531275.1649707882@sss.pgh.pa.us> <7bba5a32-65fe-04e1-7c36-efd963a625c9@postgresql.org> <807242.1649776780@sss.pgh.pa.us> <20220606135529.GV29853@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox