pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Justin Pryzby <pryzby@telsasoft.com>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: pgsql-hackers@postgresql.org, Daniel Verite <daniel@manitou-mail.org>
Subject: Re: ICU for global collation
Date: Mon, 27 Jun 2022 20:32:05 -0500
Message-ID: <20220628013205.GH19662@telsasoft.com> (raw)
In-Reply-To: <97f2c29e-24d9-3660-60cf-9138c0c47d90@enterprisedb.com>
References: <20220121135119.ywszwl4353v5dzh5@jrouhaud>
	<e2061949-f731-fd60-8b0b-3bae75095b4f@enterprisedb.com>
	<20220121161331.xn7fhtfg5j2ucilb@jrouhaud>
	<87e93704-b7f7-71f6-161d-8713e6334ed3@enterprisedb.com>
	<704405ed-f1fa-d2a7-b9f9-48a07fb45648@enterprisedb.com>
	<20220625151930.GH22452@telsasoft.com>
	<20220626035124.t36putp232nfl5im@jrouhaud>
	<54b7bd53-ae10-6258-21e6-b799f7480803@enterprisedb.com>
	<YrlRS847pNnxwu+v@paquier.xyz>
	<97f2c29e-24d9-3660-60cf-9138c0c47d90@enterprisedb.com>

On Mon, Jun 27, 2022 at 09:10:29AM +0200, Peter Eisentraut wrote:
> On 27.06.22 08:42, Michael Paquier wrote:
> > On Mon, Jun 27, 2022 at 08:23:59AM +0200, Peter Eisentraut wrote:
> > > On 26.06.22 05:51, Julien Rouhaud wrote:
> > > > On Sat, Jun 25, 2022 at 10:19:30AM -0500, Justin Pryzby wrote:
> > > > > > +	if (GET_MAJOR_VERSION(old_cluster.major_version) <= 1500)
> > > 
> > > I think the fix here is to change <= to < ?
> > 
> > Yes.
> 
> Ok, committed.
> 
> (I see now that in the context of pg_upgrade, writing <= 1400 is equivalent,
> but I find that confusing, so I did < 1500.)

I suggested using <= 1400 for consistency with the other code, and per
bc1fbc960.  But YMMV.

-- 
Justin

view thread (111+ messages)  latest in thread

Message-ID: <20220628013205.GH19662@telsasoft.com>
Permalink:  ../20220628013205.GH19662@telsasoft.com/
Also on:    postgresql.org/message-id/20220628013205.GH19662@telsasoft.com

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, peter.eisentraut@enterprisedb.com, michael@paquier.xyz, rjuju123@gmail.com, daniel@manitou-mail.org
  Subject: Re: ICU for global collation
  In-Reply-To: <20220628013205.GH19662@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox