pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Guillaume Lelarge <guillaume@lelarge.info>
Cc: Benoit Lobréau <benoit.lobreau@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>
Cc: Dr. Michael Meskes <michael.meskes@credativ.com>
Subject: Re: Probable memory leak with ECPG and AIX
Date: Sat, 2 Jul 2022 20:43:46 -0700
Message-ID: <20220703034346.GC2378460@rfd.leadboat.com> (raw)
In-Reply-To: <1132802.1656819428@sss.pgh.pa.us>
References: <20211212073411.GA2218865@rfd.leadboat.com>
	<CAPE8EZ4ca2s5tDVHZzQ=iGh+rD8VX5r4Gk8zTTEeh9VaDOMnuQ@mail.gmail.com>
	<CAPE8EZ42eWAemjj58DO0WArCMDG2VYWut38aAGo9V8QH8ETqrg@mail.gmail.com>
	<20220101074055.GA54621@rfd.leadboat.com>
	<2865639.1641054902@sss.pgh.pa.us>
	<20220102000750.GB54621@rfd.leadboat.com>
	<20220418041645.GA1134228@rfd.leadboat.com>
	<964681.1656788014@sss.pgh.pa.us>
	<20220703030619.GB2378460@rfd.leadboat.com>
	<1132802.1656819428@sss.pgh.pa.us>

On Sat, Jul 02, 2022 at 11:37:08PM -0400, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > Thanks for reviewing.  Pushed with that comment.  prairiedog complains[1]:
> >   ld: common symbols not allowed with MH_DYLIB output format with the -multi_module option
> >   connect.o definition of common _ecpg_clocale (size 4)
> 
> Blah.
> 
> > I bet this would fix it:
> 
> > -locale_t	ecpg_clocale;
> > +locale_t	ecpg_clocale = (locale_t) 0;
> 
> Hmm, I was considering suggesting that just on stylistic grounds,
> but decided it was too nitpicky even for me.
> Do you want me to test it on prairiedog?

Sure, if it's easy enough.  If not, I'm 87% sure it will suffice.





view thread (20+ messages)  latest in thread

Message-ID: <20220703034346.GC2378460@rfd.leadboat.com>
Permalink:  ../20220703034346.GC2378460@rfd.leadboat.com/
Also on:    postgresql.org/message-id/20220703034346.GC2378460@rfd.leadboat.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: noah@leadboat.com, tgl@sss.pgh.pa.us, guillaume@lelarge.info, benoit.lobreau@gmail.com, michael.meskes@credativ.com
  Subject: Re: Probable memory leak with ECPG and AIX
  In-Reply-To: <20220703034346.GC2378460@rfd.leadboat.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox