From: Justin Pryzby <pryzby@telsasoft.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org, Bruce Momjian <bruce@momjian.us>
Cc: Shruthi Gowda <gowdashru@gmail.com>
Subject: Re: pg15b2: large objects lost on upgrade
Date: Wed, 6 Jul 2022 06:56:00 -0500
Message-ID: <20220706115600.GU13040@telsasoft.com> (raw)
In-Reply-To: <CA+TgmoY0bREBNKWFkOzpg7is3DQK7gsnMoA+bBzE9+y9kdjhng@mail.gmail.com>
References: <20220701231413.GI13040@telsasoft.com>
<CA+TgmobwWGO98mWB1X2xpo25gatKsjpENtnYaUFcvVs7raRQPg@mail.gmail.com>
<20220702154917.GM13040@telsasoft.com>
<CA+Tgmobg=5hAVCcTD2277AiuqCL0Vp38ETepuR2hAxeqSyR9kg@mail.gmail.com>
<20220705165605.GR13040@telsasoft.com>
<CA+TgmoY0bREBNKWFkOzpg7is3DQK7gsnMoA+bBzE9+y9kdjhng@mail.gmail.com>
On Tue, Jul 05, 2022 at 02:40:21PM -0400, Robert Haas wrote:
> On Tue, Jul 5, 2022 at 12:56 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
> > My patch also leaves a 0 byte file around from initdb, which is harmless, but
> > dirty.
> >
> > I've seen before where a bunch of 0 byte files are abandoned in an
> > otherwise-empty tablespace, with no associated relation, and I have to "rm"
> > them to be able to drop the tablespace. Maybe that's a known issue, maybe it's
> > due to crashes or other edge case, maybe it's of no consequence, and maybe it's
> > already been fixed or being fixed already. But it'd be nice to avoid another
> > way to have a 0 byte files - especially ones named with system OIDs.
>
> Do you want to add something to the patch to have pg_upgrade remove
> the stray file?
I'm looking into it, but it'd help to hear suggestions about where to put it.
My current ideas aren't very good.
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, robertmhaas@gmail.com, bruce@momjian.us, gowdashru@gmail.com
Subject: Re: pg15b2: large objects lost on upgrade
In-Reply-To: <20220706115600.GU13040@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox