From: Nathan Bossart <nathandbossart@gmail.com>
To: David Steele <david@pgmasters.net>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: remove more archiving overhead
Date: Thu, 7 Jul 2022 09:18:25 -0700
Message-ID: <20220707161825.GA2205004@nathanxps13> (raw)
In-Reply-To: <17147b74-5465-9a7a-ae27-305d1200482c@pgmasters.net>
References: <20220222011948.GA3850532@nathanxps13>
<20220222173711.GA3852671@nathanxps13>
<20220222195229.GA42988@nathanxps13>
<20220224.141349.1809640551882183816.horikyota.ntt@gmail.com>
<20220224175553.GA660690@nathanxps13>
<20220407222327.GA1363808@nathanxps13>
<768e6cb3-256d-9c0b-1797-62420ffca7ae@oss.nttdata.com>
<CA+TgmoaeTe4oUT39A4nt=8LD6UJ5u0vcmGc5+Aksn-4oKRb8-w@mail.gmail.com>
<17147b74-5465-9a7a-ae27-305d1200482c@pgmasters.net>
On Thu, Jul 07, 2022 at 10:46:23AM -0400, David Steele wrote:
> On 7/7/22 10:37, Robert Haas wrote:
>> On Thu, Jul 7, 2022 at 10:03 AM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>> > Thanks for updating the patch. It looks good to me.
>> > Barring any objection, I'm thinking to commit it.
>>
>> I don't object, but I just started to wonder whether the need to
>> handle re-archiving of the same file cleanly is as well-documented as
>> it ought to be.
>
> +1, but I don't think that needs to stand in the way of this patch, which
> looks sensible to me as-is. I think that's what you meant, but just wanted
> to be sure.
Yeah, this seems like something that should be documented. I can pick this
up. I believe this is an existing problem, but this patch could make it
more likely.
> There are plenty of ways that already-archived WAL might get archived again
> and this is just one of them.
What are some of the others? I was aware of the case that was fixed in
ff9f111, where we might try to re-archive a file with different contents,
but I'm curious what other ways you've seen this happen.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, david@pgmasters.net, robertmhaas@gmail.com, masao.fujii@oss.nttdata.com, horikyota.ntt@gmail.com
Subject: Re: remove more archiving overhead
In-Reply-To: <20220707161825.GA2205004@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox