pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: allow building trusted languages without the untrusted versions
Date: Wed, 13 Jul 2022 11:53:50 -0700
Message-ID: <20220713185350.GA3118442@nathanxps13> (raw)
In-Reply-To: <849661f1-85a3-2833-5477-059a9b58e70f@enterprisedb.com>
References: <1290329.1653326228@sss.pgh.pa.us>
	<CA+TgmoY-Xy_ObfYVUTSamD8BmW8npaktbr65JtnkW-c1VQobVA@mail.gmail.com>
	<1333860.1653338790@sss.pgh.pa.us>
	<CA+TgmoYZKLxftaZZvj4_-zHQ27CBeUs+KvggyU3qS79-7aQEPA@mail.gmail.com>
	<1354561.1653345768@sss.pgh.pa.us>
	<CA+TgmoZ_c0j4ut87_QCFm697Qq5Z_u66VZt2PYenfZVjUT1qRA@mail.gmail.com>
	<20220524172851.GA1191690@nathanxps13>
	<CA+TgmobOQiDXpYq6TgaCzH3p5c0Fko-wXqCjgd5YsR6RsX31vA@mail.gmail.com>
	<20220524205841.GA1254661@nathanxps13>
	<849661f1-85a3-2833-5477-059a9b58e70f@enterprisedb.com>

Given the discussion in this thread, I intend to mark the commitfest entry
as Withdrawn shortly.  Before I do, I thought I'd first check whether 0001
[0] might be worthwhile independent of $SUBJECT.  This change separates the
[un]trusted handler and validator functions for PL/Perl so that we no
longer need to inspect pg_language to determine whether to use the trusted
or untrusted code path.  I was surprised to learn that you can end up with
PL/PerlU even if you've specified the trusted handler/validator functions.
Besides bringing things more in line with how PL/Tcl does things, this
change simplifies function lookup in plperl_proc_hash.  I suppose such a
change might introduce a compatibility break for users who are depending on
this behavior, but I don't know if that's worth worrying about.

[0] https://www.postgresql.org/message-id/attachment/133940/v1-0001-Do-not-use-pg_language-to-determine-...

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (35+ messages)  latest in thread

Message-ID: <20220713185350.GA3118442@nathanxps13>
Permalink:  ../20220713185350.GA3118442@nathanxps13/
Also on:    postgresql.org/message-id/20220713185350.GA3118442@nathanxps13

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, peter.eisentraut@enterprisedb.com, robertmhaas@gmail.com, tgl@sss.pgh.pa.us
  Subject: Re: allow building trusted languages without the untrusted versions
  In-Reply-To: <20220713185350.GA3118442@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox