From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org, Andres Freund <andres@anarazel.de>
Subject: Re: make -C libpq check fails obscurely if tap tests are disabled
Date: Fri, 22 Jul 2022 22:19:45 +0200
Message-ID: <20220722201945.wk22sn2evf4enztn@alvherre.pgsql> (raw)
In-Reply-To: <20220722182323.4org2cermfs4j6zl@alvherre.pgsql>
On 2022-Jul-22, Alvaro Herrera wrote:
> It's not very common -- we do have some target-specific variable
> assignments, but none of them use 'export'. I saw somewhere that this
> works from Make 3.77 onwards, and we require 3.80, so it should be okay.
> The buildfarm will tell us ...
Hm, so prairiedog didn't like this:
make -C libpq all
Makefile:146: *** multiple target patterns. Stop.
but I don't understand which part it is upset about. The rules are:
check installcheck: export PATH := $(CURDIR)/test:$(PATH)
check: test-build all
$(prove_check)
installcheck: test-build all
$(prove_installcheck)
I think "multiple target patterns" means it doesn't like the fact that
there are two colons in the first line. But if I use a recursive
assignment (PATH = ...), that of course doesn't work because PATH appears on
both sides of the assignment:
Makefile:146: *** Recursive variable 'PATH' references itself (eventually). Stop.
Now, maybe that colon is not the issue and perhaps the problem can be
solved by splitting the rule:
check: export PATH := $(CURDIR)/test:$(PATH)
installcheck: export PATH := $(CURDIR)/test:$(PATH)
According to 32568.1536241083@sss.pgh.pa.us, prairiedog is on Make 3.80.
Hmmm.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
Voy a acabar con todos los humanos / con los humanos yo acabaré
voy a acabar con todos (bis) / con todos los humanos acabaré ¡acabaré! (Bender)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, andrew@dunslane.net, pryzby@telsasoft.com, andres@anarazel.de
Subject: Re: make -C libpq check fails obscurely if tap tests are disabled
In-Reply-To: <20220722201945.wk22sn2evf4enztn@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox