pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: michael@paquier.xyz
Cc: gurjeet@singh.im
Cc: pgsql-hackers@postgresql.org
Subject: Re: Unprivileged user can induce crash by using an SUSET param in PGOPTIONS
Date: Fri, 22 Jul 2022 15:33:59 -0700
Message-ID: <20220722223359.GB3998906@nathanxps13> (raw)
In-Reply-To: <729330.1658516182@sss.pgh.pa.us>
References: <CABwTF4U9v4u3L2GWU6ZVxK-6NtvEMarrgAj2Vq8=wE_g1Tkncw@mail.gmail.com>
	<CABwTF4WXCbjEpVRq+G+MZeJEXU=2evYMb_DVdzXpWap5cczkcQ@mail.gmail.com>
	<Ytn2ssEKdzPFM3Vf@paquier.xyz>
	<20220722.151600.1094104349120879204.horikyota.ntt@gmail.com>
	<729330.1658516182@sss.pgh.pa.us>

On Fri, Jul 22, 2022 at 02:56:22PM -0400, Tom Lane wrote:
> +	/*
> +	 * If this is an interactive session, load any libraries that should be
> +	 * preloaded at backend start.  Since those are determined by GUCs, this
> +	 * can't happen until GUC settings are complete, but we want it to happen
> +	 * during the initial transaction in case anything that requires database
> +	 * access needs to be done.
> +	 */
> +	if (!bootstrap &&
> +		!IsAutoVacuumWorkerProcess() &&
> +		!IsBackgroundWorker &&
> +		!am_walsender)
> +		process_session_preload_libraries();

I worry that this will be easily missed when adding new types of
non-interactive sessions, but I can't claim to have a better idea.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (25+ messages)  latest in thread

Message-ID: <20220722223359.GB3998906@nathanxps13>
Permalink:  ../20220722223359.GB3998906@nathanxps13/
Also on:    postgresql.org/message-id/20220722223359.GB3998906@nathanxps13

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, tgl@sss.pgh.pa.us, horikyota.ntt@gmail.com, michael@paquier.xyz, gurjeet@singh.im
  Subject: Re: Unprivileged user can induce crash by using an SUSET param in PGOPTIONS
  In-Reply-To: <20220722223359.GB3998906@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox