pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Simon Riggs <simon.riggs@enterprisedb.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Amit Langote <amitlangote09@gmail.com>
Cc: Japin Li <japinli@hotmail.com>
Cc: Zhihong Yu <zyu@yugabyte.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Daniel Westermann <dwe@dbi-services.com>
Cc: Erik Rijkers <er@xs4all.nl>
Cc: Jaime Casanova <jcasanov@systemguards.com.ec>
Cc: Andres Freund <andres@anarazel.de>
Subject: Re: MERGE and parsing with prepared statements
Date: Fri, 19 Aug 2022 08:30:16 -0500
Message-ID: <20220819133016.GV26426@telsasoft.com> (raw)
In-Reply-To: <20220812115325.5b4xuvrqr66wvixp@alvherre.pgsql>
References: <CANbhV-GfBmWHpzMUhzCfk9bZE8+eCHy8UQyozd1veu3V3yoU8A@mail.gmail.com>
	<20220812115325.5b4xuvrqr66wvixp@alvherre.pgsql>

On Fri, Aug 12, 2022 at 01:53:25PM +0200, Alvaro Herrera wrote:
> On 2022-Aug-12, Simon Riggs wrote:
> 
> > Sorry, but I disagree with this chunk in the latest commit,
> > specifically, changing the MATCHED from after to before the NOT
> > MATCHED clause.

3d895bc84 also moved a semicolon into the middle of the sql statement.

> > The whole point of the second example was to demonstrate that the
> > order of the MATCHED/NOT MATCHED clauses made no difference.
> > 
> > By changing the examples so they are the same, the sentence at line
> > 573 now makes no sense.
> 
> Hmm, I thought the point of the example was to show that you can replace
> the table in the USING clause with a query that retrieves the column;
> but you're right, we lost the thing there.  Maybe it was too subtle to
> the point that I failed to understand it.  Perhaps we can put it back
> the way it was and explain these two differences (change of data source
> *and* clause ordering) more explicitly.

Evidently I misunderstood it, too.

-- 
Justin





view thread (16+ messages)  latest in thread

Message-ID: <20220819133016.GV26426@telsasoft.com>
Permalink:  ../20220819133016.GV26426@telsasoft.com/
Also on:    postgresql.org/message-id/20220819133016.GV26426@telsasoft.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, alvherre@alvh.no-ip.org, simon.riggs@enterprisedb.com, david.g.johnston@gmail.com, boekewurm+postgres@gmail.com, peter.eisentraut@enterprisedb.com, amitlangote09@gmail.com, japinli@hotmail.com, zyu@yugabyte.com, tomas.vondra@enterprisedb.com, dwe@dbi-services.com, er@xs4all.nl, jcasanov@systemguards.com.ec, andres@anarazel.de
  Subject: Re: MERGE and parsing with prepared statements
  In-Reply-To: <20220819133016.GV26426@telsasoft.com>
  References: <CANbhV-GfBmWHpzMUhzCfk9bZE8+eCHy8UQyozd1veu3V3yoU8A@mail.gmail.com> <20220812115325.5b4xuvrqr66wvixp@alvherre.pgsql> <20220819133016.GV26426@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox