public inbox for [email protected]  

help / color / mirror / Atom feed
From: Justin Pryzby <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: Daniel Gustafsson <[email protected]>
Cc: Juan José Santamaría Flecha <[email protected]>
Cc: [email protected]
Subject: Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~
Date: Fri, 26 Aug 2022 06:26:37 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <YsZnhwERsDv/[email protected]>
References: <[email protected]>
	<[email protected]>
	<CA+hUKGKoT-77HwufN6h55NpOdTHU6ukDXWiA0B3NqCn+cmQR7w@mail.gmail.com>
	<[email protected]>
	<YqrKOPvi/[email protected]>
	<[email protected]>
	<CA+hUKGL1p7BHdZc_GEBYkLarPzFEAYKd_HXA_NJ_ct4dJCD-iw@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<YsZnhwERsDv/[email protected]>

On Thu, Jul 07, 2022 at 01:56:39PM +0900, Michael Paquier wrote:
> On Thu, Jul 07, 2022 at 09:11:57AM +0900, Michael Paquier wrote:
> > Okay, thanks for confirming.  I think that I'll give it a try today
> > then, my schedule would fit nicely with the buildfarm monitoring.
> 
> And I have applied that, after noticing that the MinGW was complaining
> because _WIN32_WINNT was not getting set like previously and removing
> _WIN32_WINNT as there is no need for it anymore.  The CI has reported
> green for all my tests, so I am rather confident to not have messed up
> something.  Now, let's see what the buildfarm members tell.  This
> should take a couple of hours..

If I'm not wrong, there's some lingering comments which could be removed since
495ed0ef2.

src/bin/pg_ctl/pg_ctl.c: * on NT4. That way, we don't break on NT4.
src/bin/pg_ctl/pg_ctl.c: * On NT4, or any other system not containing the required functions, will
src/bin/pg_ctl/pg_ctl.c:                 * NT4 doesn't have CreateRestrictedToken, so just call ordinary
src/port/dirmod.c: *    Win32 (NT4 and newer).
src/backend/port/win32/socket.c:                /* No error, zero bytes (win2000+) or error+WSAEWOULDBLOCK (<=nt4) */

-- 
Justin





view thread (32+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox