public inbox for [email protected]  
help / color / mirror / Atom feed
From: Michael Paquier <[email protected]>
To: Thomas Munro <[email protected]>
Cc: Justin Pryzby <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: Daniel Gustafsson <[email protected]>
Cc: Juan José Santamaría Flecha <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~
Date: Mon, 12 Sep 2022 09:08:50 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+hUKG+oFsGCN3HkG_-_U9fKqpQkL48RZ-0AKg7H5biLnXC76A@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<CA+hUKG+BMdcaCe=P-EjMoLTCr3zrrzqbcVE=8h5LyNsSVHKXZA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CA+hUKG+oFsGCN3HkG_-_U9fKqpQkL48RZ-0AKg7H5biLnXC76A@mail.gmail.com>

On Mon, Sep 12, 2022 at 09:42:25AM +1200, Thomas Munro wrote:
> When looking the function up it made sense to use the name ending in
> '...A', but when calling directly I think we shouldn't use the A
> suffix, we should let the <winldap.h> macros do that for us[1].  (I
> wondered for a moment if that would even make Windows and Unix code
> the same, but sadly not due to the extra NULL arguments.)

Good idea, I did not noticed this part.  This should work equally, so
done this way and applied.  I am keeping an eye on the buildfarm.
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
  download

view thread (32+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox