From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: pgsql-hackers@postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Andres Freund <andres@anarazel.de>
Subject: Re: Different compression methods for FPI
Date: Wed, 7 Sep 2022 03:57:29 -0500
Message-ID: <20220907085729.GW31833@telsasoft.com> (raw)
In-Reply-To: <Yxg6NJryuxThgGLF@paquier.xyz>
References: <YKTa4+kTFkb3EIBs@paquier.xyz>
<20210525044444.GV3676@telsasoft.com>
<YKymshLnYZeD0cue@paquier.xyz>
<3252174C-C21D-4711-A038-5230DE465BAE@yandex-team.ru>
<YLWWPaq/KnVS24J4@paquier.xyz>
<20210614012412.GA31772@telsasoft.com>
<20220902115511.GY31833@telsasoft.com>
<20220905002320.GD31833@telsasoft.com>
<Yxbs6TZAh5KwMg/v@paquier.xyz>
<Yxg6NJryuxThgGLF@paquier.xyz>
On Wed, Sep 07, 2022 at 03:29:08PM +0900, Michael Paquier wrote:
> At the end, I have not taken the approach to use errdetail() for this
> problem as errormsg_buf is designed to include an error string. So, I
> have finished by refining the error messages generated in
> RestoreBlockImage(), consuming them with an ERRCODE_INTERNAL_ERROR.
The cases involving max_block_id, has_image and in_use are still "can't
happen" cases, which used to hit elog(), and INTERNAL_ERROR sounds right
for them.
But that's also what'll happen when attempting to replay WAL using a postgres
build which doesn't support the necessary compression method. I ran into this
while compiling postgres locally while reporting the recovery_prefetch bug,
when I failed to compile --with-zstd. Note that basebackup does:
src/backend/backup/basebackup_zstd.c- ereport(ERROR,
src/backend/backup/basebackup_zstd.c- (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
src/backend/backup/basebackup_zstd.c: errmsg("zstd compression is not supported by this build")));
src/backend/backup/basebackup_zstd.c- return NULL; /* keep compiler quiet */
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, michael@paquier.xyz, x4mmm@yandex-team.ru, thomas.munro@gmail.com, pg@bowt.ie, andres@anarazel.de
Subject: Re: Different compression methods for FPI
In-Reply-To: <20220907085729.GW31833@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox