pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Jacob Champion <jchampion@timescale.com>
Cc: Jan Wieck <jan@wi3ck.info>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Zhihong Yu <zyu@yugabyte.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Robins Tharakan <tharakan@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: pg_upgrade failing for 200+ million Large Objects
Date: Thu, 8 Sep 2022 16:34:07 -0700
Message-ID: <20220908233407.GA2244644@nathanxps13> (raw)
In-Reply-To: <CAAWbhmgUb8p7ff_ZX5jCvqM=ipPxbbDJTXMNVzH-Ho_CXVkRHA@mail.gmail.com>
References: <6cccaa33-c263-b8a2-b064-985605d33d25@wi3ck.info>
	<988415.1616528159@sss.pgh.pa.us>
	<872315a8-99fc-da4e-463d-784cfb5a025d@wi3ck.info>
	<1010642.1616532950@sss.pgh.pa.us>
	<802b96e9-f5e1-015c-dfb9-8756974b11fc@wi3ck.info>
	<0263bf35-05d6-02a1-519b-b7895a918314@wi3ck.info>
	<20220825003227.GA1456581@nathanxps13>
	<663393ca-b2ff-26f0-2e2d-adc942aff4fd@timescale.com>
	<20220908231807.GA2242918@nathanxps13>
	<CAAWbhmgUb8p7ff_ZX5jCvqM=ipPxbbDJTXMNVzH-Ho_CXVkRHA@mail.gmail.com>

On Thu, Sep 08, 2022 at 04:29:10PM -0700, Jacob Champion wrote:
> On Thu, Sep 8, 2022 at 4:18 PM Nathan Bossart <nathandbossart@gmail.com> wrote:
>> IIUC the main benefit of this approach is that it isn't dependent on
>> binary-upgrade mode, which seems to be a goal based on the discussion
>> upthread [0].
> 
> To clarify, I agree that pg_dump should contain the core fix. What I'm
> questioning is the addition of --dump-options to make use of that fix
> from pg_upgrade, since it also lets the user do "exciting" new things
> like --exclude-schema and --include-foreign-data and so on. I don't
> think we should let them do that without a good reason.

Ah, yes, I think that is a fair point.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (93+ messages)  latest in thread

Message-ID: <20220908233407.GA2244644@nathanxps13>
Permalink:  ../20220908233407.GA2244644@nathanxps13/
Also on:    postgresql.org/message-id/20220908233407.GA2244644@nathanxps13

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, jchampion@timescale.com, jan@wi3ck.info, tgl@sss.pgh.pa.us, bruce@momjian.us, zyu@yugabyte.com, andrew@dunslane.net, magnus@hagander.net, tharakan@gmail.com, peter.eisentraut@enterprisedb.com
  Subject: Re: pg_upgrade failing for 200+ million Large Objects
  In-Reply-To: <20220908233407.GA2244644@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox