pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Zhang Mingli <zmlpostgres@gmail.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Maxim Orlov <orlovmg@gmail.com>
Cc: Pavel Borisov <pashkin.elfe@gmail.com>
Cc: Aleksander Alekseev <aleksander@timescale.com>
Cc: pgsql-hackers@lists.postgresql.org, Stephen Frost <sfrost@snowman.net>
Cc: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Ilya Anfimov <ilan@tzirechnoy.com>
Subject: Re: Add 64-bit XIDs into PostgreSQL 15
Date: Tue, 20 Sep 2022 04:26:43 -0500
Message-ID: <20220920092643.GB31833@telsasoft.com> (raw)
In-Reply-To: <d90f891e-548a-4477-bf8c-b7b038b8db52@Spark>
References: <CALT9ZEFmpuCT65vXZVN=axxoKTr6xjj-kDGNa=KXvMuCfbOcbQ@mail.gmail.com>
	<20220715121658.GI18011@telsasoft.com>
	<CALT9ZEEyB0P8iLb20y3NKMVK2kNbwzVSH1n1eb1mQg9EJ-5f9A@mail.gmail.com>
	<CAJ7c6TPHBwU87+oRdTUHVy7bKNnCfZPywJJBKuUhUcNQQ3xUaw@mail.gmail.com>
	<CALT9ZEHiPQJn8GjZpjfCJTNg-fD+innHxTCEH-CX=zYyH81=sw@mail.gmail.com>
	<CAFiTN-s6=M3hHo_Rjic8WvHJe=-m+vc3aa4uQwh2pLFkHR8XJQ@mail.gmail.com>
	<CAFiTN-vZ26KdkBzE1xwJqi0E6y87HH_m-od54fq1FfirTmG+9A@mail.gmail.com>
	<CACG=ezZUhMiBSrjj4ZhxXyaoOP3zf-YVAh+0UK7YhOQ=N88efw@mail.gmail.com>
	<CACG=ezaSke1CJrbG110RwiqTF-Dw0H8nqhwGVd1eMCB369yhZw@mail.gmail.com>
	<d90f891e-548a-4477-bf8c-b7b038b8db52@Spark>

On Tue, Sep 20, 2022 at 03:37:47PM +0800, Zhang Mingli wrote:
> I want to have a look at these patches, but apply on master failed:

Yeah, it's likely to break every week or more often.

You have a few options:

0) resolve the conflict yourself;

1) apply the patch to the commit that the authors sent it against, or
some commit before the conflicting file(s) were changed in master.  Like
maybe "git checkout -b 64bitxids f66d997fd".

2) Use the last patch that cfbot successfully created.  You can read the
patch on github's web interface, or add cfbot's user as a remote to use
the patch locally for review and/or compilation.  Something like "git
remote add cfbot https://github.com/postgresql-cfbot/postgresql; git
fetch cfbot commitfest/39/3594; git checkout -b 64bitxids
cfbot/commitfest/39/3594".  (Unfortunately, cfbot currently squishes the
patch series into a single commit and loses the commit message).

You could also check the git link in the commitfest, to see if the
author has already rebased it, but haven't yet mailed the rebased patch
to the list.  In this case, that's not true, but you could probably use
the author's branch on github, too.
https://commitfest.postgresql.org/39/3594/

-- 
Justin





view thread (232+ messages)  latest in thread

Message-ID: <20220920092643.GB31833@telsasoft.com>
Permalink:  ../20220920092643.GB31833@telsasoft.com/
Also on:    postgresql.org/message-id/20220920092643.GB31833@telsasoft.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, zmlpostgres@gmail.com, dilipbalaut@gmail.com, orlovmg@gmail.com, pashkin.elfe@gmail.com, aleksander@timescale.com, sfrost@snowman.net, aekorotkov@gmail.com, andres@anarazel.de, ilan@tzirechnoy.com
  Subject: Re: Add 64-bit XIDs into PostgreSQL 15
  In-Reply-To: <20220920092643.GB31833@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox